Re: FlashPoint card hanging system (BT-950)

Matthew Wilcox (Matthew.Wilcox@genedata.com)
Sun, 3 Oct 1999 09:54:58 +0200

On Sat, Oct 02, 1999 at 04:34:14PM -0500, William Lash wrote:
> I am not competely convinced that the way I added the udelay() call to the
> macros is 100% correct. I changed
>
> #define OS_InPortByte(port) inb(port)
>
> to:
>
> #define OS_InPortByte(port) (udelay(2),inb(port))

Better (more usual) is:

#define OS_InPortByte(port) do { udelay(2); inb(port); } while (0)

-- 
Matthew Wilcox <willy@bofh.ai>
"Windows and MacOS are products, contrived by engineers in the service of
specific companies. Unix, by contrast, is not so much a product as it is a
painstakingly compiled oral history of the hacker subculture." - N Stephenson


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/