Re: PATCHES (unused code/vars...) for 2.3.18ac8

Alan Cox (alan@lxorguk.ukuu.org.uk)
Fri, 24 Sep 1999 13:44:28 +0100 (BST)


> > > +asmlinkage long sys_sched_rr_get_interval(struct timespec *interval)
> > > {
> >
> > This is a syscall you cant go around deleting arguments
>
> well, as i am on a solaris box for now, i can't check it but it seems to
> me it's not in the 169 official syscalls and thus may be optimized by
> not push/pop unused parameters. Am i wrong ?

Its a syscall. If you are going to post patches please test them.

> > > - struct ei_device *ei_local = (struct ei_device *) dev->priv;
> > >
> > > /* This can't happen unless somebody forgot to call ethdev_init(). */
> > This variable IS used.
> Where ?

Non x86

>
> > > -int apm_get_info(char *buf, char **start, off_t fpos, int length, int dummy)
> > > +int apm_get_info(char *buf)
> >
> > These are parameters passed by the calling function
>
> but there are not used !

Please read a book on the C language. It doesn't matter if they are used or
not you can't go around deleting them. This is beginner level programming.

> > These are values used on other platforms
>
> maybe we can turn this in a macro that developp in
> __real_flush_tlb_range on ia32 and other archs where it'sn't used ?

What for - gcc isnt stupid.

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/