Re: PATCHES (unused code/vars...) for 2.3.18ac8

Thierry vignaud (tvignaud@mandrakesoft.com)
Fri, 24 Sep 1999 13:57:44 +0200


Alan Cox wrote:

> > -asmlinkage long sys_sched_rr_get_interval(pid_t pid, struct timespec *interval)
> > +asmlinkage long sys_sched_rr_get_interval(struct timespec *interval)
> > {
>
> This is a syscall you cant go around deleting arguments

well, as i am on a solaris box for now, i can't check it but it seems to
me it's not in the 169 official syscalls and thus may be optimized by
not push/pop unused parameters. Am i wrong ?

> > +++ drivers/net/8390.c Fri Sep 24 01:59:19 1999
> > @@ -149,7 +149,6 @@
> > int ei_open(struct net_device *dev)
> > {
> > unsigned long flags;
> > - struct ei_device *ei_local = (struct ei_device *) dev->priv;
> >
> > /* This can't happen unless somebody forgot to call ethdev_init(). */
>
> This variable IS used.

Where ?

> >
> > -int apm_get_info(char *buf, char **start, off_t fpos, int length, int dummy)
> > +int apm_get_info(char *buf)
>
> These are parameters passed by the calling function

but there are not used !

> > -static inline void flush_tlb_range(struct mm_struct *mm,
> > - unsigned long start, unsigned long end)
> > +static inline void flush_tlb_range(struct mm_struct *mm)
>
> These are values used on other platforms

maybe we can turn this in a macro that developp in
__real_flush_tlb_range on ia32 and other archs where it'sn't used ?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/