Re: v2.3.17pre1 - Patches, Complaints, Questions and Jubilations

Nick Holloway (Nick.Holloway@alfie.demon.co.uk)
5 Sep 1999 20:51:35 +0100


alan@lxorguk.ukuu.org.uk (Alan Cox) writes:
> > > >+ /* Suppress compiler warning. See EI_SHIFT in 8390.h for details */
> > > >+ (void)ei_local;
> > > Or use __attribute__ ((__unused__)) on the declaration.
> > Even better, just wrap the definition with #ifndef __i386__
>
> All of which just looks ugly. So I leave it as is

Merely pimples on the great pustulating boil.

It is far from obvious (proven empirically) that E8390_CMD (et al)
use EI_SHIFT, which in turn _may_ require that "ei_local->reg_offset[]"
to be valid in the current scope.

IMHO.

-- 
 `O O'  | Home: Nick.Holloway@alfie.demon.co.uk  http://www.alfie.demon.co.uk/
// ^ \\ | Work: Nick.Holloway@parallax.co.uk

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/