Re: es1371 midi_read patch

Thomas Sailer (sailer@ife.ee.ethz.ch)
Thu, 02 Sep 1999 19:54:40 +0200

Messages sorted by: [ date ][ thread ][ subject ][ author ]
Next message: Immanuel Scholz: "kernel panic report"
Previous message: Jeff Garzik: "Re: ACPI still breaks PIIX4 IDE in 2.3.16"
Maybe in reply to: Andy Sloane: "es1371 midi_read patch"

Andy Sloane wrote:
>
> When doing a read() call on /dev/midi using the es1371 driver, the driver
> waits for the entire buffer you specify to be filled. Well, this basically
> defeats the purpose of realtime midi input unless you poll it with a
> one-byte buffer.
>
> Attached is a quick fix. I haven't even looked at the 1370 driver, but a
> similar patch might apply there.

The driver already implements the O_NONBLOCK flag, therefore your
patch is useless and changes the behaviour of the driver
in a nonstandard way.

Tom

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

Next message: Immanuel Scholz: "kernel panic report"
Previous message: Jeff Garzik: "Re: ACPI still breaks PIIX4 IDE in 2.3.16"
Maybe in reply to: Andy Sloane: "es1371 midi_read patch"