Re: [PATCH] 2.3.14: Supply "si_band" in queued SIGIOs

Jamie Lokier (lkd@tantalophile.demon.co.uk)
Fri, 20 Aug 1999 11:40:37 +0200

Stephen C. Tweedie wrote:
> si.si_code = SI_SIGIO;
> - - si.si_pid = fown->pid;
> - - si.si_uid = fown->uid;
> + si.si_band = band;
> si.si_fd = fa->fa_fd;

Hi Stephen,

Does this mean the si_band field was always zero before, or that it was
unreliable? I'd like to know if autoconfing for existence of si_band is
enough to use the returned value reliably.

btw, you may want to include the attached for completeness.

thanks,
-- Jamie

diff -u linux-2.2.8/fs/fcntl.c.devel linux-2.2.8/fs/fcntl.c
--- linux-2.2.8/fs/fcntl.c.devel Wed May 12 00:44:17 1999
+++ linux-2.2.8/fs/fcntl.c Wed May 12 00:44:32 1999
@@ -162,7 +162,8 @@
err = filp->f_owner.signum;
break;
case F_SETSIG:
- if (arg <= 0 || arg > _NSIG) {
+ /* arg == 0 restores default behaviour. */
+ if (arg < 0 || arg > _NSIG) {
err = -EINVAL;
break;
}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/