Re: [PATCH] wrong include in i8259.c in 2.3.14

Mike A. Harris (andre@suse.com)
Thu, 19 Aug 1999 18:34:11 -0700 (PDT)


Regardless,

The contents of <linux/tasks.h> are in <linux/threads.h>.

Now the real question, where did you state the location of the file??

grep -i tasks.h `find . -name '*.[ch]'`
./include/asm-mips/hardirq.h:#include <linux/tasks.h>
./include/asm-alpha/smp.h:#include <linux/tasks.h>
./include/asm-sparc/irq.h:#include <linux/tasks.h> /* For NR_CPUS */
./include/asm-sparc/smp.h:#include <linux/tasks.h>
./include/asm-sparc/ap1000/apreg.h:#include <linux/tasks.h>
./include/asm-sparc/hardirq.h:#include <linux/tasks.h>
./include/asm-sparc/spinlock.h:#include <linux/tasks.h> /* For NR_CPUS */
./include/asm-sparc/softirq.h:#include <linux/tasks.h> /* For NR_CPUS */
./include/asm-ppc/smp.h:#include <linux/tasks.h>
./include/asm-sparc64/hardirq.h:#include <linux/tasks.h>
./include/asm-arm/hardirq.h:#include <linux/tasks.h>
./arch/sparc/kernel/irq.c:#include <linux/tasks.h>
./arch/sparc/kernel/cpu.c:#include <linux/tasks.h>
./arch/sparc/kernel/devices.c:#include <linux/tasks.h>
./arch/sparc/kernel/smp.c:#include <linux/tasks.h>
./arch/sparc/kernel/sun4d_smp.c:#include <linux/tasks.h>
./arch/sparc/kernel/sun4m_smp.c:#include <linux/tasks.h>
./arch/sparc/lib/debuglocks.c:#include <linux/tasks.h> /* For NR_CPUS */
./arch/sparc/mm/fault.c:#include <linux/tasks.h>
./arch/sparc/ap1000/aplib.c: in any order, so we don't know which tasks have started up when this
./arch/sparc/ap1000/msc.c:#include <linux/tasks.h>
./arch/sparc/ap1000/sync.c:#include <linux/tasks.h>
./arch/ppc/kernel/smp.c:#include <linux/tasks.h>
./arch/sparc64/kernel/devices.c:#include <linux/tasks.h>
./arch/sparc64/kernel/smp.c:#include <linux/tasks.h>

The above was done against a pristine kernel tree of 2.3.14, where is the
file you are referencing "linux/arch/i386/kernel/i8259.c".

I think I just got nailed hook, line, sinker.............gad......

Andre Hedrick
The Linux IDE guy

On 19 Aug 1999, david parsons wrote:

> In article <linux.kernel.Pine.LNX.4.10.9908191456480.6581-100000@home.suse.com>,
> <andre@suse.com> wrote:
>
> >> I've found that i8259 tries to include linux/tasks.h which is gone.
> >> so obvious patch is:
> >>
> >> --- linux/arch/i386/kernel/i8259.c.orig Thu Aug 19 22:04:38 1999
> >> +++ linux/arch/i386/kernel/i8259.c Thu Aug 19 22:04:47 1999
> >> @@ -10,7 +10,6 @@
> >> #include <linux/malloc.h>
> >> #include <linux/random.h>
> >> #include <linux/smp.h>
> >> -#include <linux/tasks.h>
> >
> >+#include <linux/threads.h>
> >
> >is the rest of the answer. tasks.h -> threads.h
>
> But it doesn't seem to actually be needed; i8259.c compiles without
> complaint with that include commented out.
>
> ____
> david parsons \bi/ Of course this is compiled with 2.7.0...
> \/
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.rutgers.edu
> Please read the FAQ at http://www.tux.org/lkml/
>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/