--1421910094-1723552155-934830318=:25754
Content-Type: TEXT/PLAIN; charset=US-ASCII
Hi Alan.
The enclosed patch file fixes various warning messages that appear
when compiling kernel 2.2.11 with everything hard compiled in, and
which basically fall in the following categories:
1. Functions always defined, but only called when the driver
is compiled as a module. This accounts for most of the
changes in the patch, and basically amounts to putting a
'#ifdef MODULE'...'#endif' pair around the routines in
question.
2. Several occurrances of "#ifdef 0" replaced with "#if 0".
3. One occurrance of "if (ptr = NULL)" replacing "=" by "==".
4. One occurance of a static procedure being called before
it is defined, fixed by moving the definition after the
call.
5. One occurrance of a header file missing a #define that
actually occurred in one of the .c files that use it,
fixed by moving the #define from the .c file to the
header file, along with the '#ifndef TWO_THREE' that
surrounded it.
6. Two occurrances of TLan_GetBit being called for its
side effect and the return value being ignored, fixed
by explicitly stating that the return value is being
discarded by using (void) casts.
Also, the very last hunk disposes of some warning messages about two
variables in sonicvibes.c being used uninitialised by the simple
method of explicitly initialising them to 0 when defined, and thus
allows the comment saying that the warning is bogus to be removed as
well.
Best wishes from Riley.
+----------------------------------------------------------------------+
| There is something frustrating about the quality and speed of Linux |
| development, ie., the quality is too high and the speed is too high, |
| in other words, I can implement this XXXX feature, but I bet someone |
| else has already done so and is just about to release their patch. |
+----------------------------------------------------------------------+
* ftp://ftp.MemAlpha.cx/pub/rhw/Linux
* http://www.MemAlpha.cx/kernel.versions.html
--1421910094-1723552155-934830318=:25754
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="warnings.diff"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.LNX.4.10.9908162005180.25754@ps.cus.umist.ac.uk>
Content-Description:
Content-Disposition: attachment; filename="warnings.diff"
LS0tIGxpbnV4LTIuMi4xMS9kcml2ZXJzL2NoYXIvZ2VuZXJpY19zZXJpYWwu
aH4JTW9uIEF1ZyAgOSAyMDowNTowOSAxOTk5DQorKysgbGludXgtMi4yLjEx
L2RyaXZlcnMvY2hhci9nZW5lcmljX3NlcmlhbC5oCU1vbiBBdWcgMTYgMTE6
MTM6MzIgMTk5OQ0KQEAgLTEyLDYgKzEyLDEwIEBADQogI2lmbmRlZiBHRU5F
UklDX1NFUklBTF9IDQogI2RlZmluZSBHRU5FUklDX1NFUklBTF9IDQogDQor
I2lmbmRlZiBUV09fVEhSRUUNCisjZGVmaW5lIHdhaXRfcXVldWVfaGVhZF90
CXN0cnVjdCB3YWl0X3F1ZXVlICoNCisjZW5kaWYNCisNCiBzdHJ1Y3QgcmVh
bF9kcml2ZXIgew0KICAgdm9pZCAgICAgICAgICAgICAgICAgICAgKCpkaXNh
YmxlX3R4X2ludGVycnVwdHMpICh2b2lkICopOw0KICAgdm9pZCAgICAgICAg
ICAgICAgICAgICAgKCplbmFibGVfdHhfaW50ZXJydXB0cykgKHZvaWQgKik7
DQotLS0gbGludXgtMi4yLjExL2RyaXZlcnMvY2hhci9wbXMuY34JV2VkIEp1
biAgMiAxOToyOToyOCAxOTk5DQorKysgbGludXgtMi4yLjExL2RyaXZlcnMv
Y2hhci9wbXMuYwlNb24gQXVnIDE2IDE3OjQ3OjE3IDE5OTkNCkBAIC0xMDI0
LDEyICsxMDI0LDYgQEANCiAJcmV0dXJuIDA7DQogfQ0KIA0KLXN0YXRpYyB2
b2lkIHNodXRkb3duX21lZGlhdmlzaW9uKHZvaWQpDQotew0KLQlyZWxlYXNl
X3JlZ2lvbihpb19wb3J0LDMpOw0KLQlyZWxlYXNlX3JlZ2lvbigweDlBMDEs
IDEpOw0KLX0NCi0NCiAvKg0KICAqCU1vZHVsZSBzdHVmZg0KICAqLw0KQEAg
LTEwNjEsNiArMTA1NSwxMiBAQA0KIA0KIE1PRFVMRV9QQVJNKGlvX3BvcnQs
ImkiKTsNCiBNT0RVTEVfUEFSTShtZW1fYmFzZSwiaSIpOw0KKw0KK3N0YXRp
YyB2b2lkIHNodXRkb3duX21lZGlhdmlzaW9uKHZvaWQpDQorew0KKwlyZWxl
YXNlX3JlZ2lvbihpb19wb3J0LDMpOw0KKwlyZWxlYXNlX3JlZ2lvbigweDlB
MDEsIDEpOw0KK30NCiANCiB2b2lkIGNsZWFudXBfbW9kdWxlKHZvaWQpDQog
ew0KLS0tIGxpbnV4LTIuMi4xMS9kcml2ZXJzL2NoYXIvcmFkaW8tY2FkZXQu
Y34JTW9uIEF1ZyAgOSAyMDowNDozOSAxOTk5DQorKysgbGludXgtMi4yLjEx
L2RyaXZlcnMvY2hhci9yYWRpby1jYWRldC5jCU1vbiBBdWcgMTYgMTE6MjU6
MDMgMTk5OQ0KQEAgLTU0MywyMiArNTQzLDYgQEANCiAJTlVMTA0KIH07DQog
DQotX19pbml0ZnVuYyhpbnQgY2FkZXRfaW5pdChzdHJ1Y3QgdmlkZW9faW5p
dCAqdikpDQotew0KLSNpZm5kZWYgTU9EVUxFICAgICAgICANCi0gICAgICAg
IGlmKGNhZGV0X3Byb2JlKCk8MCkgew0KLQkgICAgICAgIHJldHVybiBFSU5W
QUw7DQotCX0NCi0jZW5kaWYNCi0JaWYodmlkZW9fcmVnaXN0ZXJfZGV2aWNl
KCZjYWRldF9yYWRpbyxWRkxfVFlQRV9SQURJTyk9PS0xKQ0KLQkJcmV0dXJu
IC1FSU5WQUw7DQotCQkNCi0JcmVxdWVzdF9yZWdpb24oaW8sMiwiY2FkZXQi
KTsNCi0JcHJpbnRrKEtFUk5fSU5GTyAiQURTIENhZGV0IFJhZGlvIENhcmQg
YXQgMHgleFxuIixpbyk7DQotCXJldHVybiAwOw0KLX0NCi0NCi0NCiAjaWZu
ZGVmIE1PRFVMRQ0KIHN0YXRpYyBpbnQgY2FkZXRfcHJvYmUodm9pZCkNCiB7
DQpAQCAtNTc4LDYgKzU2MiwyMSBAQA0KIH0NCiAjZW5kaWYNCiANCisNCitf
X2luaXRmdW5jKGludCBjYWRldF9pbml0KHN0cnVjdCB2aWRlb19pbml0ICp2
KSkNCit7DQorI2lmbmRlZiBNT0RVTEUgICAgICAgIA0KKyAgICAgICAgaWYo
Y2FkZXRfcHJvYmUoKTwwKSB7DQorCSAgICAgICAgcmV0dXJuIEVJTlZBTDsN
CisJfQ0KKyNlbmRpZg0KKwlpZih2aWRlb19yZWdpc3Rlcl9kZXZpY2UoJmNh
ZGV0X3JhZGlvLFZGTF9UWVBFX1JBRElPKT09LTEpDQorCQlyZXR1cm4gLUVJ
TlZBTDsNCisJCQ0KKwlyZXF1ZXN0X3JlZ2lvbihpbywyLCJjYWRldCIpOw0K
KwlwcmludGsoS0VSTl9JTkZPICJBRFMgQ2FkZXQgUmFkaW8gQ2FyZCBhdCAw
eCV4XG4iLGlvKTsNCisJcmV0dXJuIDA7DQorfQ0KIA0KIA0KICNpZmRlZiBN
T0RVTEUNCi0tLSBsaW51eC0yLjIuMTEvZHJpdmVycy9jaGFyL3N4LmN+CU1v
biBBdWcgIDkgMjA6MDU6MDkgMTk5OQ0KKysrIGxpbnV4LTIuMi4xMS9kcml2
ZXJzL2NoYXIvc3guYwlNb24gQXVnIDE2IDExOjEzOjE1IDE5OTkNCkBAIC0z
MzQsNyArMzM0LDYgQEANCiAjaWZuZGVmIFRXT19USFJFRQ0KIC8qIFRoZXNl
IGFyZSBuZXcgaW4gMi4zLiBUaGUgc291cmNlIG5vdyB1c2VzIDIuMyBzeW50
YXgsIGFuZCBoZXJlIGlzIA0KICAgIHRoZSBjb21wYXRpYmlsaXR5IGRlZmlu
ZS4uLiAqLw0KLSNkZWZpbmUgd2FpdF9xdWV1ZV9oZWFkX3Qgc3RydWN0IHdh
aXRfcXVldWUgKg0KICNkZWZpbmUgREVDTEFSRV9NVVRFWChuYW1lKSBzdHJ1
Y3Qgc2VtYXBob3JlIG5hbWUgPSBNVVRFWA0KICNkZWZpbmUgREVDTEFSRV9X
QUlUUVVFVUUod2FpdCwgY3VycmVudCkgc3RydWN0IHdhaXRfcXVldWUgd2Fp
dCA9IHsgY3VycmVudCwgTlVMTCB9DQogDQotLS0gbGludXgtMi4yLjExL2Ry
aXZlcnMvbmV0L2FyY25ldC5jfglNb24gQXVnICA5IDIwOjA0OjM5IDE5OTkN
CisrKyBsaW51eC0yLjIuMTEvZHJpdmVycy9uZXQvYXJjbmV0LmMJTW9uIEF1
ZyAxNiAxNzo0OTowOSAxOTk5DQpAQCAtNDcyLDcgKzQ3Miw3IEBADQogI2lm
ZGVmIENPTkZJR19BUkNORVRfMTA1MQ0KICAgLyogSW5pdGlhbGl6ZSB0aGUg
UkZDMTA1MS1lbmNhcCBwcm90b2NvbCBkcml2ZXIgKi8NCiAgIGxwLT5zZGV2
PShzdHJ1Y3QgZGV2aWNlICopa21hbGxvYyhzaXplb2Yoc3RydWN0IGRldmlj
ZSkrMTAsR0ZQX0tFUk5FTCk7DQotICBpZihscC0+c2RldiA9IE5VTEwpDQor
ICBpZihscC0+c2RldiA9PSBOVUxMKQ0KICAgew0KICAgCWlmKGxwLT5lZGV2
KQ0KICAgCQlrZnJlZShscC0+ZWRldik7DQotLS0gbGludXgtMi4yLjExL2Ry
aXZlcnMvbmV0L3RsYW4uY34JVHVlIEFwciAxMyAwMDoxODozMyAxOTk5DQor
KysgbGludXgtMi4yLjExL2RyaXZlcnMvbmV0L3RsYW4uYwlNb24gQXVnIDE2
IDE4OjQ0OjUyIDE5OTkNCkBAIC0yNTI4LDEzICsyNTI4LDEzIEBADQogDQog
CWZvciAoIGkgPSAoIDB4MSA8PCAoIG51bV9iaXRzIC0gMSApICk7IGk7IGkg
Pj49IDEgKSB7DQogCQlUTGFuX0NsZWFyQml0KCBUTEFOX05FVF9TSU9fTUNM
Sywgc2lvICk7DQotCQlUTGFuX0dldEJpdCggVExBTl9ORVRfU0lPX01DTEss
IHNpbyApOw0KKwkJKHZvaWQpIFRMYW5fR2V0Qml0KCBUTEFOX05FVF9TSU9f
TUNMSywgc2lvICk7DQogCQlpZiAoIGRhdGEgJiBpICkNCiAJCQlUTGFuX1Nl
dEJpdCggVExBTl9ORVRfU0lPX01EQVRBLCBzaW8gKTsNCiAJCWVsc2UNCiAJ
CQlUTGFuX0NsZWFyQml0KCBUTEFOX05FVF9TSU9fTURBVEEsIHNpbyApOw0K
IAkJVExhbl9TZXRCaXQoIFRMQU5fTkVUX1NJT19NQ0xLLCBzaW8gKTsNCi0J
CVRMYW5fR2V0Qml0KCBUTEFOX05FVF9TSU9fTUNMSywgc2lvICk7DQorCQko
dm9pZCkgVExhbl9HZXRCaXQoIFRMQU5fTkVUX1NJT19NQ0xLLCBzaW8gKTsN
CiAJfQ0KIA0KIH0gLyogVExhbl9NaWlTZW5kRGF0YSAqLw0KLS0tIGxpbnV4
LTIuMi4xMS9kcml2ZXJzL3NvdW5kL3NvbmljdmliZXMuY34JTW9uIEF1ZyAg
OSAyMDowNDo0MCAxOTk5DQorKysgbGludXgtMi4yLjExL2RyaXZlcnMvc291
bmQvc29uaWN2aWJlcy5jCU1vbiBBdWcgMTYgMTg6NDg6MDAgMTk5OQ0KQEAg
LTUwNCw5ICs1MDQsOCBAQA0KIHN0YXRpYyB1bnNpZ25lZCBzZXRwbGwoc3Ry
dWN0IHN2X3N0YXRlICpzLCB1bnNpZ25lZCBjaGFyIHJlZywgdW5zaWduZWQg
cmF0ZSkNCiB7DQogCXVuc2lnbmVkIGxvbmcgZmxhZ3M7DQotCXVuc2lnbmVk
IGNoYXIgciwgbSwgbjsNCisJdW5zaWduZWQgY2hhciByLCBtPTAsIG49MDsN
CiAJdW5zaWduZWQgeG0sIHhuLCB4ciwgeGQsIG1ldHJpYyA9IH4wVTsNCi0J
LyogdGhlIHdhcm5pbmdzIGFib3V0IG0gYW5kIG4gdXNlZCB1bmluaXRpYWxp
emVkIGFyZSBib2d1cyBhbmQgbWF5IHNhZmVseSBiZSBpZ25vcmVkICovDQog
DQogCWlmIChyYXRlIDwgNjI1MDAwL0FEQ01VTFQpDQogCQlyYXRlID0gNjI1
MDAwL0FEQ01VTFQ7DQo=
--1421910094-1723552155-934830318=:25754--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/