Re: get_empty_filp() is not SMP safe. [f_version problem]

Matthew Wilcox (Matthew.Wilcox@genedata.com)
Thu, 12 Aug 1999 17:29:48 +0200

On Thu, Aug 12, 1999 at 04:34:48PM +0200, Manfred Spraul wrote:
> Actually, it seems that f_version is completely broken:
> * it's only read during read_dir.
> * it's only set in get_empty_filp() and during file read/write operations,
> ie. it seems that for directories, it is never updated.
>
> I think it can be completely removed, because i_sem prevents parallel
> accesses.

I think you've misunderstood the purpose of i_version. It's supposed to
record the version of a file so that if the inode is reused it still has
a different NFS filehandle.

-- 
Matthew Wilcox <willy@bofh.ai>
"Windows and MacOS are products, contrived by engineers in the service of
specific companies. Unix, by contrast, is not so much a product as it is a
painstakingly compiled oral history of the hacker subculture." - N Stephenson


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/