Re: 2.2.10 SMP spin_lock bug....

Ingo Molnar (mingo@chiara.csoma.elte.hu)
Thu, 5 Aug 1999 15:43:51 +0200 (CEST)


On Thu, 5 Aug 1999, Andrea Arcangeli wrote:

> >If the lockup your system is triggering matches that someone else is
> >seeing (it looks like it =), then the following fix should work: in
> >kernel/fork.c around line 613, change the p->processor = NO_PROC_ID; to
> >p->processor = current->processor; Apparently this fix will be included
> >in 2.2.11.
>
> How can NO_PROC_ID trigger a lockup?

it's wakeup() doing a nonchecked dereference on p->processor - which is
wrong. (Davem noticed the bug). setting p->processor to the parent's
processor is conceptually the right thing to do anyway, so it's even a
performance patch.

-- mingo

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/