Re: [PATCH] PLIP driver support for parallel ports with no IRQ

Tim Waugh (tim@cyberelk.demon.co.uk)
Sun, 1 Aug 1999 14:04:45 +0100 (GMT)


On Sun, 1 Aug 1999, Nimrod Zimerman wrote:

> -/* Bottom halfs */
> +inline static void enable_parport_interrupts (struct device *dev)
> +{
> + if (dev->irq != -1)
> + outb (PAR_INTR_ON, PAR_CONTROL(dev));
> +}

Actually, it would be good if this used:

struct parport *port = dev->pardev->port;
port->ops->enable_irq (port);

instead, for this kind of thing.

> + sema_init (&nl->killed_timer_sem, 0);

In 2.2.x I think you have to say:

nl->kill_timer_sem = MUTEX_LOCKED;

Tim.
*/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/