> On a brand new 2.2.10 from scratch with unrelated minor tweaks
> to init/main.c the compile failed with something about
> "sk_something called with too few arguments."
> Sorry, that's all I have. This is with SKnet MCA support, which
> I duly turned off, which is why the report is vague. Emailme if
> you want the .config.
For reference, here's what I get...
Q> make[3]: Entering directory `/home/cus/rhw/linux-2.2.10/drivers/net'
Q> gcc -D__KERNEL__ -I/home/cus/rhw/linux-2.2.10/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -pipe -fno-strength-reduce -m486 -malign-loops=2 -malign-jumps=2 -malign-functions=2 -DCPU=586 -c -o sk_mca.o sk_mca.c
Q> sk_mca.c:860: macro `dev_kfree_skb' used with too many (2) args
Q> make[3]: *** [sk_mca.o] Error 1
Everywhere else that I can find it, that macro only has one parameter,
but just there, it can have two parameters...
Here's my patch against that. The resulting kernel at least compiles.
===8<=== CUT ===>8===
--- linux-2.2.10/drivers/net/sk_mca.c~ Mon Jun 7 22:34:54 1999
+++ linux-2.2.10/drivers/net/sk_mca.c Sat Jul 24 15:27:47 1999
@@ -851,15 +851,9 @@
restore_flags(flags);
tx_done:
- /* When did that change exactly ? */
-
-#if LINUX_VERSION_CODE >= 0x020200
dev_kfree_skb(skb);
-#else
- dev_kfree_skb(skb, FREE_WRITE);
-#endif
return retval;
}
/* return pointer to Ethernet statistics */
===8<=== CUT ===>8===
Best wishes from Riley.
+----------------------------------------------------------------------+
| There is something frustrating about the quality and speed of Linux |
| development, ie., the quality is too high and the speed is too high, |
| in other words, I can implement this XXXX feature, but I bet someone |
| else has already done so and is just about to release their patch. |
+----------------------------------------------------------------------+
* ftp://ftp.MemAlpha.cx/pub/rhw/Linux
* http://www.MemAlpha.cx/kernel.versions.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/