1)size_t == int
This causes a lot of "int format, different argument" warnings in
printk's. While I know that they're not that important, I'd like not
to see these if possible.
What's the normal way to fix these sorts of things? Is an explicit
cast eg:
diff -ur linux.vanilla/fs/nfs/nfs2xdr.c linux/fs/nfs/nfs2xdr.c
--- linux.vanilla/fs/nfs/nfs2xdr.c Wed Jul 21 12:05:32 1999
+++ linux/fs/nfs/nfs2xdr.c Wed Jul 21 10:40:29 1999
@@ -446,7 +446,7 @@
"NFS: server %s, readdir reply truncated\n",
clnt->cl_server);
printk(KERN_WARNING "NFS: nr=%d, slots=%d, len=%d\n",
- nr, (end - p), len);
+ nr, (int)(end - p), len);
clnt->cl_flags |= NFS_CLNTF_BUFSIZE;
break;
...the approved method? I think this is quite ugly, but have done it
for all the offending printk's in my config.
2)Similar problems with long int format being passed an int arg.
Such as:
diff -ur linux.vanilla/fs/nfsd/export.c linux/fs/nfsd/export.c
--- linux.vanilla/fs/nfsd/export.c Tue Dec 29 19:42:25 1998
+++ linux/fs/nfsd/export.c Wed Jul 21 11:48:09 1999
@@ -236,7 +236,7 @@
dprintk("exp_export called for %s:%s (%x/%ld fl %x).\n",
nxp->ex_client, nxp->ex_path,
- nxp->ex_dev, nxp->ex_ino, nxp->ex_flags);
+ nxp->ex_dev, (long)nxp->ex_ino, nxp->ex_flags);
dev = to_kdev_t(nxp->ex_dev);
ino = nxp->ex_ino;
What do you think? I have patched my kernel to do these casts, with
(seemingly) no problems. If there's a "right way" to do it, I'd like
to do it and submit my "warning-squash" patch in its entirety.
If I'm wasting my time, do say.
Sean
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/