lookup_swap_cache: waiting on a page without holding the count?

Trond Myklebust (trond.myklebust@fys.uio.no)
23 Jun 1999 18:13:28 +0200


Hi

Is the call to __wait_on_page that is made in the lookup_swap_cache
function correct? Shouldn't we rather be doing the following in order
to ensure the page is held during the wait?

Cheers,
Trond

--- linux-2.2.10/mm/swap_state.c-orig Wed Jan 13 18:54:50 1999
+++ linux-2.2.10/mm/swap_state.c Wed Jun 23 18:04:07 1999
@@ -262,8 +262,8 @@
#endif
return found;
}
- __free_page(found);
__wait_on_page(found);
+ __free_page(found);
}

out_bad:

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/