Re: updated apm patch

Andi Kleen (ak@muc.de)
13 Jun 1999 12:58:08 +0200


Walter.Hofmann@physik.stud.uni-erlangen.de (Walter Hofmann) writes:

> I have updated my apm patch. It switches the processor to real mode before
> it attempts to turn off the computer. This should solve the problem seen
> by a number or people.

Wouldn't it be better to share the real-mode switching code with the reboot
code in machine_restart ? Perhaps by merging both into a generic
"void execute_in_realmode(void (*)(void *))" function. Having such stub code
twice is redundant and wastes precious kernel memory. Also it is harder
to maintain, because bug fixes have to be duplicated then.

-Andi

-- 
This is like TV. I don't like TV.

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/