Re: [KBUILD] 2.x.x mkdep incorrectly handles serial.c (and probably others)

Michael Elizabeth Chastain (mec@shout.net)
Sat, 12 Jun 1999 04:45:43 -0500


Hi Keith,

All right -- when I get my box back I will write this patch up. I'm
glad to hear it's only 29 flaky lines.

My first rule about dependencies, as with any other programming,
is that they have to be correct. I care about missing dependencies
(because they are a correctness failure) and I don't care about
extra dependencies (because they are an efficiency problem at worst).

> As a general principle, I prefer "do it in one place and get it right
> once". In this case, setting HUB6 in make ...config should
> automatically set MANY_PORTS and SHARE_IRQ and not let the user
> override them. Is that possible with make ...config at the moment?

Sure. define_bool does that.

I've given up on "cleanup patches" for most things, though. At any
given moment, the kernel code has a lot of loose edges in it. I think
it's more productive to go after ancient kbuild subsystems rather than
chase subtle configuration bugs in the corpus of the code.

Michael

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/