Re: [PATCH] copy_strings cleanup for 2.3.2

Oliver Xymoron (oxymoron@waste.org)
Mon, 17 May 1999 21:17:14 -0500 (CDT)


On Sun, 16 May 1999, Andi Kleen wrote:

> > So copy_strings would be something like
> >
> > int copy_strings(int argc, char *const*argv, &bprm)
> >
> > instead of
> >
> > unsigned long copy_strings(.. horror-arguments ..)
> >
> > no?
>
> I didn't do it at first because I thought copy_strings is general purpose
> enough that it may be someday used for something else than just with
> binformats, but at a closer look you're right: it is unlikely that it
> will ever happen and it is not worth the complexity.

If you wanted to leave it generic, an inline function wrapper would do the
trick nicely.

--
 "Love the dolphins," she advised him. "Write by W.A.S.T.E.." 

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/