Re: 2.3.1-pre3 breaks hfs filesystem

Ingo Molnar (androsyn@i95.com)
Thu, 13 May 1999 08:37:32 -0600 (MDT)


This message is in MIME format. The first part should be readable text,
while the remaining parts are likely unreadable without MIME-aware tools.
Send mail to mime@docserver.cac.washington.edu for more info.

--655872-787087900-926606252=:2166
Content-Type: TEXT/PLAIN; charset=US-ASCII

The attached patch should fix the problem.

Aaron "sticking his head in a brown paper bag"

On Thu, 13 May 1999, Tim Smith wrote:

>
> Uhhh...I thought I knew C, but evidently I am mistaken, because much of
> that patch makes no sense to me. Many of the changes seemed to consist
> of replacing things of the form
>
> if ( ... || some_lvalue || ... )
>
> with
>
> if ( ... || &some_lvalue || ... )
>
> Won't &some_lvale *always* evaluate to something that is true when used
> with ||, and so the patch is effectively changing those if statements
> to
>
> if ( 1 )
>
> --Tim Smith
>
> On Wed, 12 May 1999 androsyn@i95.com wrote:
>
> > Date: Wed, 12 May 1999 21:18:04 -0400 (EDT)
> > From: androsyn@i95.com
> > To: linux-kernel@vger.rutgers.edu
> > Subject: 2.3.1-pre3 breaks hfs filesystem
> >
> > With the wait_queue changes in 2.3.1-pre3 hfs filesystem support got
> > broke. The attached patch *should* fix it. (But then again it may not ;)
> > Regardless it compiled okay here, I haven't tested it however. No mac
> > floppies with me today.
> >
> > Aaron
> >
> >
>

--655872-787087900-926606252=:2166
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="hfs.patch1"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.LNX.4.10.9905130837320.2166@some-random-machine.nailed.com>
Content-Description:
Content-Disposition: attachment; filename="hfs.patch1"

LS0tIGxpbnV4L2ZzL2hmcy9ibm9kZS5jLm9sZAlXZWQgTWF5IDEyIDE2OjUx
OjExIDE5OTkNCisrKyBsaW51eC9mcy9oZnMvYm5vZGUuYwlXZWQgTWF5IDEy
IDE2OjUyOjI0IDE5OTkNCkBAIC0yMjgsNyArMjI4LDcgQEANCiAJCQlicmVh
azsNCiANCiAJCWNhc2UgSEZTX0xPQ0tfTk9ORToNCi0JCQl3aGlsZSAoYm4t
PmxvY2sgfHwgYm4tPndxdWV1ZSkgew0KKwkJCXdoaWxlIChibi0+bG9jayB8
fCB3YWl0cXVldWVfYWN0aXZlKCZibi0+d3F1ZXVlKSkgew0KIAkJCQloZnNf
c2xlZXBfb24oJmJuLT5ycXVldWUpOw0KIAkJCX0NCiAJCQkrK2JuLT5jb3Vu
dDsNCkBAIC0zODIsNyArMzgyLDcgQEANCiAJLyogV2UgdXBkYXRlIHRoZSBs
b2NrIHN0YXRlIG9mIHRoZSBub2RlIGlmIGl0IGlzIHN0aWxsIGluIHVzZQ0K
IAkgICBvciBpZiBpdCBpcyAic3RpY2t5IiAoc3VjaCBhcyB0aGUgQi10cmVl
IGhlYWQgYW5kIHJvb3QpLg0KIAkgICBPdGhlcndpc2Ugd2UganVzdCBkZWxl
dGUgaXQuCSAqLw0KLQlpZiAoKGJuLT5jb3VudCA+IDEpIHx8IChibi0+cnF1
ZXVlKSB8fCAoYm4tPnN0aWNreSAhPSBIRlNfTk9UX1NUSUNLWSkpIHsNCisJ
aWYgKChibi0+Y291bnQgPiAxKSB8fCB3YWl0cXVldWVfYWN0aXZlKCZibi0+
cnF1ZXVlKSB8fCAoYm4tPnN0aWNreSAhPSBIRlNfTk9UX1NUSUNLWSkpIHsN
CiAJCWhmc19ibm9kZV9sb2NrKGJuciwgSEZTX0xPQ0tfTk9ORSk7DQogCX0g
ZWxzZSB7DQogCQkvKiBkaXJ0eSBidWZmZXIgaWYgd2UgKG1pZ2h0KSBoYXZl
IG1vZGlmaWVkIGl0ICovDQotLS0gbGludXgvZnMvaGZzL2J0cmVlLmMub2xk
CVdlZCBNYXkgMTIgMTY6NTQ6NDIgMTk5OQ0KKysrIGxpbnV4L2ZzL2hmcy9i
dHJlZS5jCVdlZCBNYXkgMTIgMTc6MDE6MjUgMTk5OQ0KQEAgLTE3Myw3ICsx
NzMsNyBAQA0KIAlidC0+c3lzX21kYiA9IG1kYi0+c3lzX21kYjsNCiAJYnQt
PnJlc2VydmVkID0gMDsNCiAJYnQtPmxvY2sgPSAwOw0KLQlidC0+d2FpdCA9
IE5VTEw7DQorCWluaXRfd2FpdHF1ZXVlX2hlYWQoJmJ0LT53YWl0KTsNCiAJ
YnQtPmRpcnQgPSAwOw0KIAltZW1zZXQoYnQtPmNhY2hlLCAwLCBzaXplb2Yo
YnQtPmNhY2hlKSk7DQogDQotLS0gbGludXgvZnMvaGZzL2NhdGFsb2cuYy5v
bGQJV2VkIE1heSAxMiAxNzowMjo0MyAxOTk5DQorKysgbGludXgvZnMvaGZz
L2NhdGFsb2cuYwlXZWQgTWF5IDEyIDE3OjAzOjEwIDE5OTkNCkBAIC02NDcs
NyArNjQ3LDcgQEANCiAgKi8NCiBzdGF0aWMgaW5saW5lIHZvaWQgc3RhcnRf
d3JpdGUoc3RydWN0IGhmc19jYXRfZW50cnkgKmRpcikNCiB7DQotCWlmIChk
aXItPnUuZGlyLnJlYWRlcnMgfHwgZGlyLT51LmRpci5yZWFkX3dhaXQpIHsN
CisJaWYgKGRpci0+dS5kaXIucmVhZGVycyB8fCB3YWl0cXVldWVfYWN0aXZl
KCZkaXItPnUuZGlyLnJlYWRfd2FpdCkpIHsNCiAJCWhmc19zbGVlcF9vbigm
ZGlyLT51LmRpci53cml0ZV93YWl0KTsNCiAJfQ0KIAkrK2Rpci0+dS5kaXIu
d3JpdGVyczsNCkBAIC02NTgsNyArNjU4LDcgQEANCiAgKi8NCiBzdGF0aWMg
aW5saW5lIHZvaWQgc3RhcnRfcmVhZChzdHJ1Y3QgaGZzX2NhdF9lbnRyeSAq
ZGlyKQ0KIHsNCi0JaWYgKGRpci0+dS5kaXIud3JpdGVycyB8fCBkaXItPnUu
ZGlyLndyaXRlX3dhaXQpIHsNCisJaWYgKGRpci0+dS5kaXIud3JpdGVycyB8
fCB3YWl0cXVldWVfYWN0aXZlKCZkaXItPnUuZGlyLndyaXRlX3dhaXQpKSB7
DQogCQloZnNfc2xlZXBfb24oJmRpci0+dS5kaXIucmVhZF93YWl0KTsNCiAJ
fQ0KIAkrK2Rpci0+dS5kaXIucmVhZGVyczsNCg==
--655872-787087900-926606252=:2166--

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/