Re: [patch] minor fix of MAGIC SYS RQ key [was RE: MAGIC SYS RQ Key]

Pavel Machek (pavel@atrey.karlin.mff.cuni.cz)
Sat, 8 May 1999 09:22:13 +0200


Hi!

> When using the magic sysrq key, if you release Alt before you release SysRq
> the Alt key gets stuck down. The root cause is that the up/down state of
> Alt is updated correctly in key_down but NOT in k_down. This persists until
> compute_shiftstate gets called (when you switch virtual consoles or press
> Ctrl-Alt-Shift together or ... probably other scenarios).
>
> The "mini" patch included at the bottom of this message fixes the problem.
> The patch is against 2.2.7.
>
> I would appreciate feedback from anyone that has experienced this glitch
> (and/or also from the maintainer of drivers/char/keyboard.c).
>
> This is my very first patch. Be kind. :-)

Looks good. I forwarded it to mj (author of code behind magic sysrq).

Pavel

-- 
The best software in life is free (not shareware)!		Pavel
GCM d? s-: !g p?:+ au- a--@ w+ v- C++@ UL+++ L++ N++ E++ W--- M- Y- R+

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/