Re: [PATCH] missing lock_kernel() and assorted races

Ralf Baechle (ralf@uni-koblenz.de)
Fri, 30 Apr 1999 17:05:29 +0200


On Fri, Apr 30, 1999 at 05:31:41AM -0400, Alexander Viro wrote:

> > > Linus, we have several problems under arch/:
> > >
> > > The architectures where you made the most changes don't even compile
> > > in 2.2.7 and haven't been updated in nearly half of a year :-)
> >
> > And some of the bugs appear to be in the relevant CVS trees too - although
> > the mips doesnt do SMP so its harmless
>
> Harmless it might be, if it would be restricted to missing lock_kernel();-/
> sysirix.c in both trees has UP-affecting bugs. That is, irix_fstatvfs()
> and irix_fstatvfs64() are oopsable; irix_ngetdents(), irix_getdents64()
> and irix_ngetdents64() do not protect ->readdir() with semaphore. Those
> bugs are present both in 1.16 (in mips tree) and 1.12 (in main tree).
> I'm submitting the patch to Ralf and I've merged relevant changes into the
> patch against the main tree. Patches attached.

Ok, applied to the MIPS trees with various additional cleanups.

Ralf

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/