Re: Question about 2.2.5-ac7 implementation of 'add_to_page_cache'

Trond Myklebust (trond.myklebust@fys.uio.no)
Fri, 16 Apr 1999 19:10:28 +0200 (CEST)


>>>>> " " == Alan Cox <alan@lxorguk.ukuu.org.uk> writes:

>> have removed the code that sets the 'PG_referenced' bit. Was
>> this deliberate? If so, what is the advantage?

> Oww.. thats a bug, a nasty one too.

Good. I thought as much. Patch appended

> I moved it for the folks working on stackable file systems -
> they need to use the function internally.

I'm using it too for the NFSv3 large rsize code, so I'm quite happy
with the move.

Cheers,
Trond

--- linux-2.2.5-ac7/include/linux/pagemap.h Fri Apr 16 15:39:25 1999
+++ linux-2.2.5-ac7-nfsv3/include/linux/pagemap.h Fri Apr 16 15:34:16 1999
@@ -135,6 +135,7 @@
{
atomic_inc(&page->count);
page->flags &= ~((1 << PG_uptodate) | (1 << PG_error));
+ page->flags |= (1 << PG_referenced);
page->offset = offset;
add_page_to_inode_queue(inode, page);
__add_page_to_hash_queue(page, hash);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/