Re: Linux Makefile uses 'ls', causes problems with color-ls (PATCH)

Richard B. Johnson (root@chaos.analogic.com)
Tue, 30 Mar 1999 17:22:34 -0500 (EST)


On Wed, 31 Mar 1999, Meelis Roos wrote:

> RBJ> The main Makefile uses 'ls' to 'Make modules_install' If you have
> RBJ> color-ls installed, this will fail.
>
> Why? This must be a misconfiguration of color-ls. IIRC color-ls should
> output color to a tty _only_ by default, and normal output goes to pipes
> unless you force it to output color always. At least the color-ls that I
> use on my RH 5.2 system behaves so.
>
> The patch itself seems to be a good thing - one less thing to depend on.

Well color-ls just writes to stdout. It is not, as you say misconfigured.
It defaults to a crappy brown color for executables. If you do (as
specified) in /etc/profile...

eval `dircolors`

It only then reads /etc/DIR_COLORS and creates a COLOR_LS environment
variable, containing color information just like 'termcap'.

Unless you specifically alias ls as 'ls --color=no' it will generate
color. Since the shell doesn't reference /etc/profile, I can't turn
off its defaults. A previous version of 'color-ls' worked fine because
if defaulted to no color. I updated to the latest version so I could
get rid of the last of my 'a.out' binaries. This is how I discovered
the problem.

Shell scripts should minimize the use of tools, so I think that
removing 'ls' is a good thing.

Cheers,
Dick Johnson
***** FILE SYSTEM WAS MODIFIED *****
Penguin : Linux version 2.2.4 on an i686 machine (400.59 BogoMips).
Warning : It's hard to remain at the trailing edge of technology.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/