Re: [CFT] rename patch (2.2.3)

Trond Myklebust (trond.myklebust@fys.uio.no)
Tue, 9 Mar 1999 17:46:09 +0100 (CET)


>>>>> " " == Alexander Viro <viro@math.psu.edu> writes:

>> Why have you removed the name length checking from the NFS
>> code? That is wrong, and should in any case not be a change for
>> a stable version.

> Huh??? It is done in nfs_lookup() and there is no way for
> dentry to become hashed and/or be passed to methods without
> ->lookup() approving it. All static checks (e.g. name length if
> the limit can't change) are done there. All methods except
> ->lookup() get dentries already in dcache, positive or
> negative. If lookup() refused to call d_add() and returned an
> error dentry will be silently dropped and will never make its
> way to other methods.

Oops. You're right: I paniced before having fully checked the
patch.

Sorry about that,
Trond

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/