Re: BUG in videodev.c [PATCH]
Alan Cox (alan@lxorguk.ukuu.org.uk)
Sun, 7 Mar 1999 00:46:27 +0000 (GMT)
> A mmap() will keep the file count updated, so the driver has to do _extra_
> work in order to free some memory before all mmap areas have gone away.
> The file->release() thing is called after the very last "fput" of the file
> (ie after all fd's have been closed AND all memory mappings have been
> removed).
>
> This patch looks like extra code to get around some other driver bug, and
> I'd much rather just see the driver fixed properly.
It matches the sound driver and it matches the bug reports. The code is
wrong in the sense that it ought push the vma to the driver and fix it
there but right now nobody does set the file pointer of the vma.
I think its actually right. If not then the sound and other code is wrong 8)
Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/