Re: [patch] sleep_on() done with cli() in the NFS code, 2.2.2

Alan Cox (alan@lxorguk.ukuu.org.uk)
Tue, 2 Mar 1999 16:18:05 +0000 (GMT)

Messages sorted by: [ date ][ thread ][ subject ][ author ]
Next message: Alan Cox: "Re: Setuid bits get dropped on fs-mounted partitions (2.2.2-ac7) !?!?"
Previous message: Paul Norton: "PROBLEM: Token-ring memory crash with kernel 2.1 and 2.2"
In reply to: Mike A. Harris: "Re: return of flawed amd processor?"

> there is one more place i found that does sleep_on() with cli(),
> this can lead to lockups under SMP. Are there any unsolved reports
> of lockups for NFS + SMP-2.2.2?
>
> That whole stretch of code is bogus, it should be using bh atomicity
> instead. The thing it is trying to be atomic against are events which
> are a result of packet arrival and perhaps timers as well.

That code just predates bh atomicity, its a cut and paste of some 1.2
code that has since in other protocols gone through bh atomicity and to
removing sleep_on

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

Next message: Alan Cox: "Re: Setuid bits get dropped on fs-mounted partitions (2.2.2-ac7) !?!?"
Previous message: Paul Norton: "PROBLEM: Token-ring memory crash with kernel 2.1 and 2.2"
In reply to: Mike A. Harris: "Re: return of flawed amd processor?"