Re: [patch] sleep_on() done with cli() in the NFS code, 2.2.2

• Messages sorted by: [ date ][ thread ][ subject ][ author ]
• Next message: Alexander Viro: "Re: [PATCH] this makes /proc/kcore an ELF core dump"
• Previous message: Ingo Molnar: "Re: [patch] sleep_on() done with cli(), NetROM, 2.2.2"
• Maybe in reply to: Ingo Molnar: "[patch] sleep_on() done with cli() in the NFS code, 2.2.2"

there is one more place i found that does sleep_on() with cli(),
this can lead to lockups under SMP. Are there any unsolved reports
of lockups for NFS + SMP-2.2.2?

That whole stretch of code is bogus, it should be using bh atomicity
instead. The thing it is trying to be atomic against are events which
are a result of packet arrival and perhaps timers as well.

Later,
David S. Miller
davem@redhat.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Alexander Viro: "Re: [PATCH] this makes /proc/kcore an ELF core dump"
• Previous message: Ingo Molnar: "Re: [patch] sleep_on() done with cli(), NetROM, 2.2.2"
• Maybe in reply to: Ingo Molnar: "[patch] sleep_on() done with cli() in the NFS code, 2.2.2"