> In article <m10GOb8-0007U1C@the-village.bc.nu> you write:
> >I think this fixes it
> >
> >--- drivers/net/3c509.c~ Fri Feb 26 01:55:06 1999
> >+++ drivers/net/3c509.c Fri Feb 26 13:50:58 1999
> >@@ -917,12 +917,12 @@
> > cleanup_module(void)
> > {
> > struct device *next_dev;
> >- struct el3_private *lp = (struct el3_private *)dev->priv;
> >
> > /* No need to check MOD_IN_USE, as sys_delete_module() checks. */
> > while (el3_root_dev) {
> >+ struct el3_private *lp = (struct el3_private *)el3_root_dev->priv;
> > mca_mark_as_unused(lp->mca_slot);
>
> I also needed to wrap the above line in #ifdef CONFIG_MCA as
> mca_mark_as_unused is not included if you configure the kernel without
> MCA support.
>
> There are also a couple of other locations where mca_mark_as_unused is
> used unconditionally.
Well, it can be used unconditionally as long as the file is MCA only...
(Such as ne2.c, 3c523.c, ibmmca.c, fd_mcs.c, etc.), however, it is clearly
another small bag for me to wear...
There are also some drivers that never mark the adapters as used, and some
that mark it used but not unused. They need to be fixed too...
The reason why they should be marked used/unused is for multi-detection to
work properly, and to make it possible to register the name of an adapter
without having a driver loaded for that adapter, etc.
/David Weinehall
_ _
// David Weinehall <tao@acc.umu.se> /> Northern lights wander \\
// Project MCA Linux hacker // Dance across the winter sky //
\> http://www.acc.umu.se/~tao/ </ Full colour fire </
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/