Re: [PATCH] genhd.c, kernel 2.2.1

Ernst Jan Plugge (rmc@dds.nl)
Wed, 17 Feb 1999 18:40:11 +0100 (CET)


On Wed, 17 Feb 1999, Rene Herman wrote:

> Hello everyone ...
>
> Starting with MINIX version 1.7.0, primary MINIX partitions can be
> subpartitioned, using a regular (DOS style) second-level partition table.
> This patch makes these subpartitions visible to Linux version 2.2.1.
>
> I've tested it locally with several good and bad MINIX subpartition tables.
> Any feedback appreciated!

Aaargh! We just did the same thing today... We do pretty much the same
thing you do, but we moved the call to minix_partition() down, into a new
for loop. That way, the minix minors will be allocated above any existing
extended partition. Many people expect the partitions inside the extended
partition to start at minor 5.

Our setup has:

/dev/hda1 - DOS
/dev/hda2 - Minix
/dev/hda3 - Minix test (for hacking around, this is for an undergraduate
OS lab assignment)
/dev/hda4 - Extended partition
/dev/hda5 - Linux swap
/dev/hda6 - Linux native

Both Minix partitions have "a" and "c" subpartitions. With your patch,
they would end up as hda5 thru hda8, and Linux would suddenly be on
/dev/hda10.

Personally, I think the BSD Disklabel, Solaris slices, and other foreign
partition types should also be in this second for loop.

Our patch works well over here, too. I'll try yours tomorrow.

Y.T.,

Ernst Jan Plugge - rmc@dds.nl

--
If elephants never forget, surely they have a great future as backup-media?
  -- tanuki@canis-major.daemon.co.uk

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/