Re: [patch] shaper fix for timer SMP races

Ingo Molnar (mingo@chiara.csoma.elte.hu)
Wed, 17 Feb 1999 16:20:25 +0100 (CET)


On Wed, 17 Feb 1999, Andrea Arcangeli wrote:

> >+ del_timer(&shaper->timer);
> >+ synchronize_bh(); /* wait for module code to be unused */
> xxxxxxxxxxxxxxx
>
> It's very more fun than that. The point is that we must have it not
> running _while_ del_timer() is running. It doesn't care if it's not
> running _after_ del_timer is been run.

oh, i see now. The shaper device is doing an add_timer within the timer
function. This must not run in parallel with a del_timer(), you are right.

-- mingo

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/