Can you please explain why you think my patch is not working?
Also, please send me the output of ls -lF on the device node you are
trying to mount.
I do have one theory why my patch is failing. See the line:
if ( !retval && !S_ISBLK (inode->i_mode) ) retval = -ENOTBLK;
^^
If the device is non-standard (i.e. the device node was created with
mknod(2) and not internally by the driver calling devfs_register()),
*and* the previous contents of the inode were for a block device, then
the condition fails. This means that reval will not be set to -ENOTBLK
and the fops are subsequently not filled. Hence you can't mount.
This is a braino on my part.
I suggest changing the "&&" to a "||". This should fix your problem
and also provides the desired behaviour. Please let me know if this
works for you.
> Patch against stock linux-2.2.0-pre9/fs/super.c to fix the problem
> follows:
In future, could you please provide patches against kernel+devfs,
rather than providing a replacement devfs patch? This makes it easier
for me to understand what you're doing and also makes it easier to
integrate a patch.
> @@ -1067,8 +1079,9 @@
> if (MAJOR(dev) >= MAX_BLKDEV)
> goto dput_and_out;
>
> - retval = -ENOTBLK;
> - dummy.f_op = get_blkfops(MAJOR(dev));
> + if ( !( retval = devfs_fill_file (inode, &dummy, NULL)))
> + retval = -ENOTBLK;
> + if ( retval < 0) dummy.f_op = get_blkfops(MAJOR(dev));
> if (!dummy.f_op)
> goto dput_and_out;
>
I'm assuming that this is the (only) part of the devfs patch that you
suggest changing. What you have done here is removed the check for a
block device returned from devfs. So now, the user could attempt to
mount a character device. I don't think this is a good fix to the
problem. See above for a suggested fix.
Regards,
Richard....
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/