Re: v2.2.0-pre8 - suspicious stuff in drivers/block/ide-cd.h

Jens Axboe (axboe@image.dk)
Wed, 20 Jan 1999 08:57:46 +0100

Michal Jaegermann wrote:
>
> Checking patches from pre7 to pre8 I noticed something which looks
> weird in drivers/block/ide-cd.h. Namely:
>
> @@ -307,8 +307,7 @@
> /* Drive can read from CD-R/W (CD-E) discs (orange book, part III) */
> __u8 cd_rw_read : 1; /* reserved in 1.2 */
> /* Drive supports reading CD-R discs with addressing method 2 */
> - __u8 method2 : 1; /* reserved in 1.2 */
> - __u8 reserved2 : 5;
> + __u8 reserved2 : 5;
>
> In other words, if __LITTLE_ENDIAN_BITFIELD is defined then 'method2'
> is gone. OTOH it is still there for __BIG_ENDIAN_BITFIELD. It is not
> likely that both can be right at the same time, especially when the field
> comment stays. :-)

Yes, that is an error and Linus received a patch for that the minute
I noticed.

-- 
*  Jens Axboe <axboe@image.dk>
*  Linux CD-ROM Maintainer
* "The only thing that interferes with my
*  learning is my education." -- A. Einstein


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/