Re: [PATCH] megaraid driver fix

Pavel Janik ml. (Pavel.Janik@inet.cz)
19 Jan 1999 01:34:04 +0100


From: Frode Vatvedt Fjeld <frodef@acm.org>
Date: 19 Jan 1999 00:21:53 +0100

Hi,

> The following (rather trivial) patch makes the megaraid driver work
> under 2.1 kernels for me. All it does is to include <linux/version.h>,
> to have LINUX_VERSION_CODE defined. With my kernel configuration, this

well, I'm running 2.2.0pre7 without this patch applied and everything
is ok, but see below.

> wasn't defined when compiling drivers/scsi/hosts.c, causing the
> megaraid Scsi_Host_Template to be initialized wrongly, leading to a
> jump into random memory during scsi initialization. I'd guess this
> problem only shows up when the megaraid is the only compiled-in scsi
> driver.

Hmm, my kernel is compiled with CONFIG_SCSI_AIC7XXX which is before
megaraid in hosts.c (so version.h is included), so I think your patch
is correct. Linus, please apply. Thanks.

Patch leaved here...

> --- linux-2.2.0-pre6/drivers/scsi/megaraid.h Fri Dec 18 19:12:25 1998
> +++ linux-2.2.0-pre7/drivers/scsi/megaraid.h Tue Jan 19 00:10:16 1999
> @@ -1,6 +1,10 @@
> #ifndef __MEGARAID_H__
> #define __MEGARAID_H__
>
> +#ifndef LINUX_VERSION_CODE
> +#include <linux/version.h>
> +#endif
> +
> #define IN_ISR 0x80000000L
> #define NO_INTR 0x40000000L
> #define IN_TIMEOUT 0x20000000L
>

-- 
Pavel Janík ml.
Pavel.Janik@inet.cz

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/