Re: [PATCH] New: AMD K6 write allocate

Rafael Reilova (rreilova@ececs.uc.edu)
Sun, 17 Jan 1999 14:48:39 -0500 (EST)


Hi,

You patch is OK. Just two minor comments:

1) make the enable_write_allocate an _initfunc so that the code is
discarded after boot and doesn't bloat other people's kernels (who may not
have an AMD).

2) Move the code to the amd_model function. Although currently that
function is misnamed, since it's used for the Cyrix MediaGX detection too.
Probably separate the extended cpuid part, from the real AMD specific
part. That will save some branch code (for what that may be worth).

Cheers,

Rafael

On Sun, 17 Jan 1999, Alexey Vyskubov wrote:

> Hello.
>
> > Do not forget to substitute your RAM size in
> >#define WRITE_ALLOCATE_LIMIT
>
> Thanks to Alan Cox's hint - there is no need for manual tuning now.
>
> Attached [new] version of patch (against 2.2.0pre7) should enable write
> allocate for AMD K6 model 6/7 processors. On my system it gives 5-7%
> increase in speed.
>
> --
> With best wishes,
> Alexey Vyskubov.
> This is a message. Or something silly like that.
>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/