Re: [PATCH] VFAT fixes.

Linus Torvalds (torvalds@transmeta.com)
Thu, 14 Jan 1999 21:50:22 -0800 (PST)


On Thu, 14 Jan 1999, Alexander Viro wrote:
>
> c) trivial patch to d_move() making sure that after a move we'll get
> hashed dentry, even if target was unhashed (another race).

I think this is just evil, and should never be allowed.

This code is just an excuse to let other bugs abound. If we use d_move(),
we should have made certain that both parents were locked. If that part of
your patch fixes anything, something else is wrong.

That part of your patch just hides potential real bugs, and as such is
completely unacceptable.

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/