hp100 jiffy wrap bug

Andrea Arcangeli (andrea@e-mind.com)
Mon, 11 Jan 1999 19:48:56 +0100 (CET)


In my first jiffy wrap fixed big-patch I did a mistake and I fixed it some
month ago after a bug report from an user of my arca patches.

I just sent this patch to Alan some time ago against his ac patches but it
seems it got not merged from him since I note that in my current arca-tree
there's still this diff pending.

This patch is against 2.2.0-pre6, look at the code in 2.1.131 and you'll
see that it's the right conversion to the time_* functions.

Index: hp100.c
===================================================================
RCS file: /var/cvs/linux/drivers/net/hp100.c,v
retrieving revision 1.1.1.3
retrieving revision 1.1.1.1.2.4
diff -u -r1.1.1.3 -r1.1.1.1.2.4
--- hp100.c 1999/01/09 11:54:53 1.1.1.3
+++ linux/drivers/net/hp100.c 1999/01/09 17:21:14 1.1.1.1.2.4
@@ -2798,7 +2798,7 @@
if ( hp100_inb( VG_LAN_CFG_1 ) & HP100_LINK_CABLE_ST ) break;
} while (time_after(time, jiffies));

- if ( time_before_eq(jiffies, time) ) /* no signal->no logout */
+ if ( time_after_eq(jiffies, time) ) /* no signal->no logout */
return 0;

/* Drop the VG Link by clearing the link up cmd and load addr.*/
@@ -2813,7 +2813,7 @@
} while(time_after(time, jiffies));

#ifdef HP100_DEBUG
- if (time_before_eq(jiffies, time))
+ if (time_after_eq(jiffies, time))
printk("hp100: %s: down_vg_link: Link does not go down?\n", dev->name);
#endif

Andrea Arcangeli

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/