Re: ASUS CD ROM 340 & 2.1.129+ dont work but work fine with 2.0.35+

Jens Axboe (axboe@image.dk)
Mon, 04 Jan 1999 23:18:29 +0100


This is a multi-part message in MIME format.
--------------C6491B83AFA6BD716C6729AD
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Thomas Davis wrote:
> > > well, I've got a Wearnes 32x CD, that works fine under 2.0.xx, but only
> > > works as pure cdrom drive under 2.1.xx (no audio, no eject, no extra
> > > features - but you can still mount it and read iso9660 filesystems)
> > >
> > > In fact, you get no messages out of the kernel about it - it fails when
> > > you try to query the drive for it's configuration.
> >
> > How does it fail?
> >
> it fails cdrom_mode_sense silently; I had to turn on all the error
> messages to get something out of it (underrun if I remember correctly; I
> don't have the system in front of me here..)
>
> So, in ide_cdrom_probe_capabilities, there's a do loop (close to the
> begining of the function), that if the # of attempts to get sense data
> <= 0, it just plain returns. Well, this drive tickles that, so it still
> works as stated, but all other features are disabled (even though they
> work..) I think at least, it should say something HERE, that the drive
> failed trying to get the sense data...
>
> Not sure what the drive's problem is; it works for eject/audio/door
> locking under 2.0.35; but none of the above works with 2.2.x (last
> checked with 2.2.2pre1, w/AC2)

Could you try this patch out and see if it makes any difference at all?
It's a dump of what I currently have in my tree, but I included a patch
for probe_capabilities (still doesn't try and gather sensible settings
for the drive, but it is more aggressive when probing).

-- 
*  Jens Axboe <axboe@image.dk>
*  Linux CD-ROM Maintainer
* "The only thing that interferes with my
*  learning is my education." -- A. Einstein
--------------C6491B83AFA6BD716C6729AD
Content-Type: application/octet-stream;
 name="misc_cdrom"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="misc_cdrom"

ZGlmZiAtdXIgLS1leGNsdWRlLWZyb20gL3Jvb3QvY2Ryb20vZXhjbHVkZS1mcm9tIHZpcmdp bi9kcml2ZXJzL2Jsb2NrL2lkZS1jZC5jIGxpbnV4L2RyaXZlcnMvYmxvY2svaWRlLWNkLmMK LS0tIHZpcmdpbi9kcml2ZXJzL2Jsb2NrL2lkZS1jZC5jCVdlZCBEZWMgMjMgMTY6NTY6MDEg MTk5OAorKysgbGludXgvZHJpdmVycy9ibG9jay9pZGUtY2QuYwlNb24gSmFuICA0IDIzOjA1 OjE1IDE5OTkKQEAgLTIsNyArMiw3IEBACiAgKiBsaW51eC9kcml2ZXJzL2Jsb2NrL2lkZS1j ZC5jCiAgKiBDb3B5cmlnaHQgKEMpIDE5OTQsIDE5OTUsIDE5OTYgIHNjb3R0IHNueWRlciAg PHNueWRlckBmbmFsZDAuZm5hbC5nb3Y+CiAgKiBDb3B5cmlnaHQgKEMpIDE5OTYtMTk5OCAg RXJpayBBbmRlcnNlbiA8YW5kZXJzZWVAZGViaWFuLm9yZz4KLSAqIENvcHlyaWdodCAoQykg MTk5OCBKZW5zIEF4Ym9lIGFuZCBDaHJpcyBad2lsbGluZworICogQ29weXJpZ2h0IChDKSAx OTk4LCAxOTk5IEplbnMgQXhib2UKICAqCiAgKiBNYXkgYmUgY29waWVkIG9yIG1vZGlmaWVk IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljCiAgKiBMaWNlbnNl LiAgU2VlIGxpbnV4L0NPUFlJTkcgZm9yIG1vcmUgaW5mb3JtYXRpb24uCkBAIC0yMjgsOSAr MjI4LDEzIEBACiAgKiAgICAgICAgICAgICAgICAgICAgICAgICJWaWxsZSBIYWxsaWsiIDx2 aWxsZS5oYWxsaWtAbWFpbC5lZT4uCiAgKiAgICAgICAgICAgICAgICAgICAgICAtIG90aGVy IG1pbm9yIHN0dWZmLgogICoKKyAqIDQuNTIgIEphbiAwMywgMTk5OSAgLS0gSmVucyBBeGJv ZSA8YXhib2VAaW1hZ2UuZGs+CisgKiAgICAgICAgICAgICAgICAgICAgICAtIENoZWNrIGZv ciBlbXB0eSB0cmF5IGluIHN0YXR1cyBhbmQgcmV0dXJuIENEU19OT19ESVNDLgorICogICAg ICAgICAgICAgICAgICAgICAgLSBCZSBtb3JlIGFnZ3Jlc3NpdmUgd2hlbiBwcm9iaW5nIGRy aXZlLgorICoKICAqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqLwogCi0jZGVmaW5lIElERUNEX1ZFUlNJ T04gIjQuNTEiCisjZGVmaW5lIElERUNEX1ZFUlNJT04gIjQuNTIiCiAKICNpbmNsdWRlIDxs aW51eC9tb2R1bGUuaD4KICNpbmNsdWRlIDxsaW51eC90eXBlcy5oPgpAQCAtMTc4Miw2ICsx Nzg2LDcgQEAKIAlwYy5jWzJdID0gcGFnZW5vIHwgKG1vZGVmbGFnIDw8IDYpOwogCXBjLmNb N10gPSAoYnVmbGVuID4+IDgpOwogCXBjLmNbOF0gPSAoYnVmbGVuICYgMHhmZik7CisJCiAJ cmV0dXJuIGNkcm9tX3F1ZXVlX3BhY2tldF9jb21tYW5kIChkcml2ZSwgJnBjKTsKIH0KIApA QCAtMTgwMSw2ICsxODA2LDcgQEAKIAlwYy5jWzJdID0gcGFnZW5vOwogCXBjLmNbN10gPSAo YnVmbGVuID4+IDgpOwogCXBjLmNbOF0gPSAoYnVmbGVuICYgMHhmZik7CisKIAlyZXR1cm4g Y2Ryb21fcXVldWVfcGFja2V0X2NvbW1hbmQgKGRyaXZlLCAmcGMpOwogfQogCkBAIC0yNDE5 LDYgKzI0MjUsNyBAQAogCQlzdGF0ID0gY2Ryb21fbW9kZV9zZW5zZSAoZHJpdmUsIFBBR0Vf QVVESU8sIDAsIGJ1ZmZlciwKIAkJCQkJIHNpemVvZiAoYnVmZmVyKSwgTlVMTCk7CiAJCWlm IChzdGF0KSByZXR1cm4gc3RhdDsKKwogCQlzdGF0ID0gY2Ryb21fbW9kZV9zZW5zZSAoZHJp dmUsIFBBR0VfQVVESU8sIDEsIG1hc2ssCiAJCQkJCSBzaXplb2YgKGJ1ZmZlciksIE5VTEwp OwogCQlpZiAoc3RhdCkgcmV0dXJuIHN0YXQ7CkBAIC0yNjQ5LDE3ICsyNjU2LDE5IEBACiAJ c3RydWN0IGNkcm9tX2luZm8gKmluZm8gPSBkcml2ZS0+ZHJpdmVyX2RhdGE7CiAKIAlpZiAo c2xvdF9uciA9PSBDRFNMX0NVUlJFTlQpIHsKLQogCQlzdHJ1Y3QgYXRhcGlfcmVxdWVzdF9z ZW5zZSBteV9yZXFidWY7CiAJCWludCBzdGF0ID0gY2Ryb21fY2hlY2tfc3RhdHVzIChkcml2 ZSwgJm15X3JlcWJ1Zik7CisKIAkJaWYgKHN0YXQgPT0gMCB8fCBteV9yZXFidWYuc2Vuc2Vf a2V5ID09IFVOSVRfQVRURU5USU9OKQogCQkJcmV0dXJuIENEU19ESVNDX09LOwogCiAJCWlm IChteV9yZXFidWYuc2Vuc2Vfa2V5ID09IE5PVF9SRUFEWSkgewotCQkJLyogV2l0aCBteSBO RUMyNjAsIGF0IGxlYXN0LCB3ZSBjYW4ndCBkaXN0aW5ndWlzaAotCQkJICAgYmV0d2VlbiB0 cmF5IG9wZW4gYW5kIHRyYXkgY2xvc2VkIGJ1dCBubyBkaXNjCi0JCQkgICBpbnNlcnRlZC4g Ki8KLQkJCXJldHVybiBDRFNfVFJBWV9PUEVOOyAKKwkJCS8qIE1vc3QgQ0QtUk9NIGRyaXZl cyBjYW4gZGlzdGluZ3Vpc2ggYmV0d2VlbgorCQkJICAgdHJheSBvcGVuIG9yIG5vIGRpc2Mu ICovCisJCQlpZiAobXlfcmVxYnVmLmFzYyA9PSAweDNhKQorCQkJCXJldHVybiBDRFNfTk9f RElTQzsKKwkJCWVsc2UKKwkJCQlyZXR1cm4gQ0RTX1RSQVlfT1BFTjsKIAkJfQogCiAJCXJl dHVybiBDRFNfRFJJVkVfTk9UX1JFQURZOwpAQCAtMjgzNSwyMiArMjg0NCwzNCBAQAogc3Rh dGljCiBpbnQgaWRlX2Nkcm9tX3Byb2JlX2NhcGFiaWxpdGllcyAoaWRlX2RyaXZlX3QgKmRy aXZlKQogewotCWludCBzdGF0LCBuc2xvdHMsIGF0dGVtcHRzID0gMzsKKwlpbnQgc3RhdCwg bnNsb3RzID0gMCwgYXR0ZW1wdHMgPSA1OwogIAlzdHJ1Y3QgewogCQljaGFyIHBhZFs4XTsK IAkJc3RydWN0IGF0YXBpX2NhcGFiaWxpdGllc19wYWdlIGNhcDsKIAl9IGJ1ZjsKIAotCW5z bG90cyA9IDA7Ci0KIAlpZiAoQ0RST01fQ09ORklHX0ZMQUdTIChkcml2ZSktPm5lYzI2MCkK IAkJcmV0dXJuIG5zbG90czsKIAogCWRvIHsJLyogd2Ugc2VlbSB0byBnZXQgc3RhdD0weDAx LGVycj0weDAwIHRoZSBmaXJzdCB0aW1lICg/PykgKi8KLQkJaWYgKGF0dGVtcHRzLS0gPD0g MCkKKwkJaWYgKGF0dGVtcHRzIDw9IDApIHsKKwkJCS8qIGF4Ym9lOiB0cnkgYW5kIGFkZCBz ZW5zaWJsZSBvcHRpb25zIHdoZW4KKwkJCSAgIHByb2JpbmcgZmFpbHMgKi8KKwkJCXByaW50 aygiaWRlLWNkOiBwcm9iaW5nIGNhcGFiaWxpdGllcyBvZiAlcyBmYWlsZWQuXG4iLAorCQkJ CWRyaXZlLT5uYW1lKTsKIAkJCXJldHVybiAwOworCQl9IGVsc2UgaWYgKGF0dGVtcHRzIDw9 IDIpIHsKKwkJCS8qIGJlIGFnZ3Jlc3NpdmUsIHJlc2V0IGRyaXZlIGFuZCB0cnkgYWdhaW4g Ki8KKwkJCXN0cnVjdCByZXF1ZXN0IHJlcTsKKworCQkJaWRlX2luaXRfZHJpdmVfY21kKCZy ZXEpOworCQkJcmVxLmNtZCA9IFJFU0VUX0RSSVZFX0NPTU1BTkQ7CisJCQlpZGVfZG9fZHJp dmVfY21kKGRyaXZlLCAmcmVxLCBpZGVfd2FpdCk7CisJCQljZHJvbV9zbGVlcChIWi8yMCk7 CisJCX0KIAkJc3RhdCA9IGNkcm9tX21vZGVfc2Vuc2UgKGRyaXZlLCBQQUdFX0NBUEFCSUxJ VElFUywgMCwKIAkJCQkgCShjaGFyICopJmJ1Ziwgc2l6ZW9mIChidWYpLCBOVUxMKTsKKwkJ YXR0ZW1wdHMtLTsKIAl9IHdoaWxlIChzdGF0KTsKIAogCWlmIChidWYuY2FwLmxvY2sgPT0g MCkKZGlmZiAtdXIgLS1leGNsdWRlLWZyb20gL3Jvb3QvY2Ryb20vZXhjbHVkZS1mcm9tIHZp cmdpbi9kcml2ZXJzL2Jsb2NrL2lkZS1jZC5oIGxpbnV4L2RyaXZlcnMvYmxvY2svaWRlLWNk LmgKLS0tIHZpcmdpbi9kcml2ZXJzL2Jsb2NrL2lkZS1jZC5oCU1vbiBEZWMgMjggMjM6MDk6 MzAgMTk5OAorKysgbGludXgvZHJpdmVycy9ibG9jay9pZGUtY2QuaAlNb24gSmFuICA0IDIx OjMzOjIzIDE5OTkKQEAgLTQsNyArNCw3IEBACiAgKiAgbGludXgvZHJpdmVycy9ibG9jay9p ZGVfbW9kZXMuaAogICoKICAqICBDb3B5cmlnaHQgKEMpIDE5OTYgIEVyaWsgQW5kZXJzZW4K LSAqICBDb3B5cmlnaHQgKEMpIDE5OTggIEplbnMgQXhib2UgYW5kIENocmlzIFp3aWxsaW5n CisgKiAgQ29weXJpZ2h0IChDKSAxOTk4LCAxOTk5IEplbnMgQXhib2UKICAqLwogCiAjaW5j bHVkZSA8YXNtL2J5dGVvcmRlci5oPgpAQCAtNzQ1LDcgKzc0NSw3IEBACiAKIAl7IDB4NjMw MCwgIkVuZCBvZiB1c2VyIGFyZWEgZW5jb3VudGVyZWQgb24gdGhpcyB0cmFjayIgfSwKIAot CXsgMHg2NDAwLCAiSWxsZWdhbCBtb2RlIGZvciB0aGlzIHRyYWNrIiB9LAorCXsgMHg2NDAw LCAiSWxsZWdhbCBtb2RlIGZvciB0aGlzIHRyYWNrIG9yIGluY29tcGF0aWJsZSBtZWRpdW0i IH0sCiAKIAl7IDB4YjkwMCwgIlBsYXkgb3BlcmF0aW9uIG9ib3J0ZWQgKHNpYykiIH0sCiAK ZGlmZiAtdXIgLS1leGNsdWRlLWZyb20gL3Jvb3QvY2Ryb20vZXhjbHVkZS1mcm9tIHZpcmdp bi9kcml2ZXJzL2Nkcm9tL2Nkcm9tLmMgbGludXgvZHJpdmVycy9jZHJvbS9jZHJvbS5jCi0t LSB2aXJnaW4vZHJpdmVycy9jZHJvbS9jZHJvbS5jCVdlZCBEZWMgMjMgMTY6NTY6MDEgMTk5 OAorKysgbGludXgvZHJpdmVycy9jZHJvbS9jZHJvbS5jCU1vbiBKYW4gIDQgMTc6NDI6MDAg MTk5OQpAQCAtMSw3ICsxLDcgQEAKIC8qIGxpbnV4L2RyaXZlcnMvY2Ryb20vY2Ryb20uYy4g CiAgICBDb3B5cmlnaHQgKGMpIDE5OTYsIDE5OTcgRGF2aWQgQS4gdmFuIExlZXV3ZW4uCiAg ICBDb3B5cmlnaHQgKGMpIDE5OTcsIDE5OTggRXJpayBBbmRlcnNlbiA8YW5kZXJzZWVAZGVi aWFuLm9yZz4KLSAgIENvcHlyaWdodCAoYykgMTk5OCBKZW5zIEF4Ym9lIGFuZCBDaHJpcyBa d2lsbGluZworICAgQ29weXJpZ2h0IChjKSAxOTk4LCAxOTk5IEplbnMgQXhib2UKIAogICAg TWF5IGJlIGNvcGllZCBvciBtb2RpZmllZCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBH ZW5lcmFsIFB1YmxpYwogICAgTGljZW5zZS4gIFNlZSBsaW51eC9DT1BZSU5HIGZvciBtb3Jl IGluZm9ybWF0aW9uLgpAQCAtOTYsMTEgKzk2LDE4IEBACiAgIC0tIENoZWNrIGlmIGRyaXZl IGlzIGNhcGFibGUgb2YgZG9pbmcgd2hhdCB3ZSBhc2sgYmVmb3JlIGJsaW5kbHkgY2hhbmdp bmcKICAgY2RpLT5vcHRpb25zIGluIHZhcmlvdXMgaW9jdGwuCiAgIC0tIEFkZGVkIHZlcnNp b24gdG8gcHJvYyBlbnRyeS4KKyAgCisgIDIuNTIgSmFuIDAzLCAxOTk4IC0gSmVucyBBeGJv ZSA8YXhib2VAaW1hZ2UuZGs+CisgIC0tIEZpeGVkIGFuIGVycm9yIGluIG9wZW5fZm9yX2Rh dGEgd2hlcmUgd2Ugd291bGQgc29tZXRpbWVzIG5vdCByZXR1cm4KKyAgdGhlIGNvcnJlY3Qg ZXJyb3IgdmFsdWUuIFRoYW5rcyBIdWJhIEdhc3BhciA8aHViYUBzb2Z0Y2VsbC5odT4uCisg IC0tIGlkZS1jZCAoYXQgbGVhc3QpIG5vdyByZXR1cm5zIENEU19OT19ESVNDIGluc3RlYWQg b2YgQ0RTX1RSQVlfT1BFTgorICB3aGVuIHRoZSBkcml2ZSBpcyBlbXB0eS4gQ2hlY2sgZm9y IHRoYXQgaW5zdGVhZCBvZiBrZWVwIHRyeWluZyB0byBjbG9zZQorICB0aGUgdHJheS4KIAog LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLSovCiAKLSNkZWZpbmUgUkVWSVNJT04gIlJldmlzaW9uOiAy LjUxIgotI2RlZmluZSBWRVJTSU9OICJJZDogY2Ryb20uYyAyLjUxIDE5OTgvMTIvMjAiCisj ZGVmaW5lIFJFVklTSU9OICJSZXZpc2lvbjogMi41MiIKKyNkZWZpbmUgVkVSU0lPTiAiSWQ6 IGNkcm9tLmMgMi41MiAxOTk5LzAxLzAzIgogCiAvKiBJIHVzZSBhbiBlcnJvci1sb2cgbWFz ayB0byBnaXZlIGZpbmUgZ3JhaW4gY29udHJvbCBvdmVyIHRoZSB0eXBlIG9mCiAgICBtZXNz YWdlcyBkdW1wZWQgdG8gdGhlIHN5c3RlbSBsb2dzLiAgVGhlIGF2YWlsYWJsZSBtYXNrcyBp bmNsdWRlOiAqLwpAQCAtMzQ1LDYgKzM1MiwxMSBAQAogCWlmIChjZG8tPmRyaXZlX3N0YXR1 cyAhPSBOVUxMKSB7CiAJCXJldCA9IGNkby0+ZHJpdmVfc3RhdHVzKGNkaSwgQ0RTTF9DVVJS RU5UKTsKIAkJY2RpbmZvKENEX09QRU4sICJkcml2ZV9zdGF0dXM9JWRcbiIsIHJldCk7IAor CQlpZiAocmV0ID09IENEU19OT19ESVNDKSB7CisJCQljZGluZm8oQ0RfT1BFTiwgIm9vcHMs IG5vIGRpc2MgaW4gZHJpdmVcbiIpOyAKKwkJCXJldCA9IC1FTk9NRURJVU07CisJCQlnb3Rv IGNsZWFuX3VwX2FuZF9yZXR1cm47CisJCX0KIAkJaWYgKHJldCA9PSBDRFNfVFJBWV9PUEVO KSB7CiAJCQljZGluZm8oQ0RfT1BFTiwgInRoZSB0cmF5IGlzIG9wZW4uLi5cbiIpOyAKIAkJ CS8qIGNhbi9tYXkgaSBjbG9zZSBpdD8gKi8KQEAgLTM3Niw4ICszODgsMTAgQEAKIAkJCX0K IAkJCWNkaW5mbyhDRF9PUEVOLCAidGhlIHRyYXkgaXMgbm93IGNsb3NlZC5cbiIpOyAKIAkJ fQotCQlpZiAocmV0IT1DRFNfRElTQ19PSykKKwkJaWYgKHJldCE9Q0RTX0RJU0NfT0spIHsK KwkJCXJldCA9IC1FTk9NRURJVU07CiAJCQlnb3RvIGNsZWFuX3VwX2FuZF9yZXR1cm47CisJ CX0KIAl9CiAJY2Ryb21fY291bnRfdHJhY2tzKGNkaSwgJnRyYWNrcyk7CiAJaWYgKHRyYWNr cy5lcnJvciA9PSBDRFNfTk9fRElTQykgewo= --------------C6491B83AFA6BD716C6729AD--

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/