On Thu, 31 Dec 1998, Horst von Brand wrote:
> Some funny things I saw reading the patch:
>
[snip]
> diff -u --recursive --new-file v2.2.0-pre1/linux/drivers/block/pdc4030.c
> linux/drivers/block/pdc4030.c
> --- v2.2.0-pre1/linux/drivers/block/pdc4030.c Thu May 7 22:51:48 1998
> +++ linux/drivers/block/pdc4030.c Tue Dec 29 11:24:57 1998
>
> + while (time_after(timer, jiffies));
> ^
> This is too easy to overlook. Better put the ';' on a line of its own
>
Even better put {} on the same/next line, and clearer still commented
"{ /* do nothing */ }".
>
> - while (jiffies < start) ;
> - for (; jiffies < stop; ++count) ;
> + while (time_before(jiffies, start)) ;
> + for (; time_before(jiffies, stop); ++count) ;
>
> Very confusing... put the ';' on separate lines
>
it's better with {}'s:
while (time_before(jiffies, start)) {}
for (; time_before(jiffies, stop); ++count) {}
Bryn
- --
PGP pubkeys from http://www.gytha.demon.co.uk/pubkey.asc.
Men often believe -- or pretend -- that the "Law" is something sacred, or at
least a science -- an unfounded assumption very convenient to governments.
-----BEGIN PGP SIGNATURE-----
Version: PGPfreeware 5.0i for non-commercial use
Comment: Silly comment here ...
Charset: noconv
iQA/AwUBNo0dpt94IUtvfSqaEQKWsgCg77teytW3T522aJa0mfph6eDj/toAn1Zp
lwMAxIN+eZaArvPJ9T+3/GIr
=QlAx
-----END PGP SIGNATURE-----
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/