Re: memory waste in fs/devices.c/kdevname()

Riley Williams (rhw@bigfoot.com)
Sat, 19 Dec 1998 16:17:13 +0000 (GMT)


This message is in MIME format. The first part should be readable text,
while the remaining parts are likely unreadable without MIME-aware tools.
Send mail to mime@docserver.cac.washington.edu for more info.

--1421910094-1629831787-914084233=:15313
Content-Type: TEXT/PLAIN; charset=US-ASCII

Hi Alan.

>> Please let's make it output decimal numbers, too, like everything
>> else that uses device numbers. Too many people have been confused
>> about this like there is no tomorrow.

> That would be incredibly incredibly mindbogglingly dumb

> We would then have two sets of kernels where an error on 13:00
> means two totally different devices. Much saner would be to put 0x
> in front of the output.

Better still, change the formatting such that decimal numbers are
separated by commas like they are in long directory listings. The
enclosed patch should help...

Best wishes from Riley.

--1421910094-1629831787-914084233=:15313
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="DevName.diff"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.LNX.3.96.981219161713.15313C@ps.cus.umist.ac.uk>
Content-Description:

LS0tIGxpbnV4L2ZzL0NvbmZpZy5pbi5vcmlnCVRodSBEZWMgMTcgMjA6NDU6
MjggMTk5OA0KKysrIGxpbnV4L2ZzL0NvbmZpZy5pbglTYXQgRGVjIDE5IDE2
OjEzOjA2IDE5OTgNCkBAIC04Nyw0ICs4Nyw3IEBADQogICBmaSAgICANCiBm
aQ0KIGJvb2wgJ01hY2ludG9zaCBwYXJ0aXRpb24gbWFwIHN1cHBvcnQnIENP
TkZJR19NQUNfUEFSVElUSU9ODQorY2hvaWNlICdEZXZpY2UgSUQgZm9ybWF0
JyBcDQorCSJEZWNpbWFsCUNPTkZJR19ERVZOQU1FX0RFQwlcDQorCSBIZXhh
ZGVjaW1hbAlDT05GSUdfREVWTkFNRV9IRVgiCUhleA0KIGVuZG1lbnUNCi0t
LSBsaW51eC9mcy9kZXZpY2VzLmMub3JpZwlNb24gQXVnIDI0IDIwOjMzOjEx
IDE5OTgNCisrKyBsaW51eC9mcy9kZXZpY2VzLmMJU2F0IERlYyAxOSAxNjow
OTozNCAxOTk4DQpAQCAtMzM4LDEzICszMzgsNjkgQEANCiB9Ow0KIA0KIC8q
DQorICogRGVmaW5lIG1hY3JvIHRvIGRldGVybWluZSByZXF1aXJlZCBsZW5n
dGggb2Ygc3RhdGljIGJ1ZmZlcg0KKyAqIHVzZWQgYnkga2Rldm5hbWUgcm91
dGluZSBiZWxvdy4gQW5hbHlzaXMgb2YgcmVxdWlyZW1lbnRzOg0KKyAqDQor
ICogSGV4YWRlY2ltYWwgb3V0cHV0DQorICogfn5+fn5+fn5+fn5+fn5+fn5+
DQorICogQ2FzZSAxOiBCaXRmaWVsZHMgZm9yIGJvdGggbWFqb3IgYW5kIG1p
bm9yIGRldmljZSBudW1iZXJzDQorICoJICAgYXJlIG11bHRpcGxlcyBvZiBm
b3VyIGJpdHMgaW4gbGVuZ3RoLiBJbiB0aGlzIGNhc2UsDQorICoJICAgd2Ug
cmVxdWlyZSB0aGUgZm9sbG93aW5nIG51bWJlciBvZiBieXRlcyBmb3IgdGhl
DQorICoJICAgZGVjb2RlZCBkZXZpY2UgbnVtYmVycyBhbmQgc2VwYXJhdG9y
czoNCisgKg0KKyAqCQkyICogc2l6ZW9mKGtkZXZfdCkgKyAyDQorICoNCisg
KiBDYXNlIDI6IEJpdGZpZWxkcyBmb3IgZWl0aGVyIG1ham9yIG9yIG1pbm9y
IGRldmljZSBudW1iZXJzDQorICoJICAgYXJlIE5PVCBtdWx0aXBsZXMgb2Yg
Zm91ciBiaXRzLCBidXQgdGhlIGNvbWJpbmVkDQorICoJICAgc2l6ZSBJUyBh
IG11bHRpcGxlIG9mIGZvdXIgYml0cy4gSW4gdGhpcyBjYXNlLCB3ZQ0KKyAq
CSAgIHJlcXVpcmUgdGhlIGZvbGxvd2luZyBudW1iZXIgb2YgYnl0ZXMgZm9y
IHRoZQ0KKyAqCSAgIGRlY29kZWQgZGV2aWNlIG51bWJlcnMgYW5kIHNlcGFy
YXRvcnM6DQorICoNCisgKgkJMiAqIHNpemVvZihrZGV2X3QpICsgMw0KKyAq
DQorICogQ2FzZSAzOiBCaXRmaWVsZHMgZm9yIGVpdGhlciBtaW5vciBvciBt
YWpvciBkZXZpY2UgbnVtYmVycw0KKyAqCSAgIGFyZSBOT1QgbXVsdGlwbGVz
IG9mIGZvdXIgYml0cywgbm9yIGlzIHRoZSBjb21iaW5lZA0KKyAqCSAgIHNp
emUgb2YgdGhlIHR3byBiaXRmaWVsZHMuIEluIHRoaXMgY2FzZSwgZGVwZW5k
aW5nDQorICoJICAgb24gdGhlIGV4YWN0IHNpemVzIG9mIHRoZSBpbmRpdmlk
dWFsIGJpdGZpZWxkcywgd2UNCisgKgkgICBtYXkgZ2V0IGF3YXkgd2l0aCB0
aGUgYnVmZmVyIG5lZWRlZCBmb3IgY2FzZSAyIG9yDQorICoJICAgd2UgbWF5
IG5lZWQgYW4gZXh0cmEgYnl0ZS4gVG8gYmUgc2FmZSwgd2UgYXNzdW1lIHRo
ZQ0KKyAqCSAgIGxhdHRlciwgdGh1cyByZXF1aXJpbmcgdGhlIGZvbGxvd2lu
ZyBudW1iZXIgb2YgYnl0ZXMNCisgKgkgICBmb3IgdGhlIGRlY29kZWQgZGV2
aWNlIG51bWJlcnMgYW5kIHNlcGFyYXRvcnM6DQorICoNCisgKgkJMiAqIHNp
emVvZihrZGV2X3QpICsgNA0KKyAqDQorICogRGVjaW1hbCBvdXRwdXQNCisg
KiB+fn5+fn5+fn5+fn5+fg0KKyAqIERlY2ltYWwgb3V0cHV0IGlzIG5vdCBz
byBuZWF0bHkgYXJyYW5nZWQgYXMgaGV4YWRlY2ltYWwgb3V0cHV0LA0KKyAq
IGFuZCB3ZSBjYW4gZWFzaWx5IHJlcXVpcmUgc2V2ZXJhbCBtb3JlIGRpZ2l0
cyB0aGFuIGlzIHRoZSBjYXNlDQorICogZm9yIGhleGFkZWNpbWFsIG51bWJl
cnMuIEZvciBleGFtcGxlLCBhIDMyLWJpdCBudW1iZXIgcmVxdWlyZXMNCisg
KiA4IGhleCBkaWdpdHMsIGJ1dCAxMSBkZWNpbWFsIGRpZ2l0cy4gQSBzYWZl
IGFwcHJveGltYXRpb24gYXBwZWFycw0KKyAqIHRvIGJlIHRvIGFzc3VtZSB0
aGF0IGRlY2ltYWwgbnVtYmVycyB3aWxsIGF0IG1vc3Qgb2NjdXB5IDUwJQ0K
KyAqIG1vcmUgc3BhY2UgdGhhbiBoZXhhZGVjaW1hbCBudW1iZXJzLg0KKyAq
Lw0KKyNpZmRlZiBDT05GSUdfREVWTkFNRV9IRVgNCisjZGVmaW5lIERFVl9C
VUZTSVpFCSgyICogc2l6ZW9mKGtkZXZfdCkgKyA0KQ0KKyNlbHNlDQorI2Rl
ZmluZSBERVZfQlVGU0laRQkoMyAqIHNpemVvZihrZGV2X3QpICsgNikNCisj
ZmkNCisNCisvKg0KICAqIFByaW50IGRldmljZSBuYW1lIChpbiBkZWNpbWFs
LCBoZXhhZGVjaW1hbCBvciBzeW1ib2xpYykgLQ0KICAqIGF0IHByZXNlbnQg
aGV4YWRlY2ltYWwgb25seS4NCiAgKiBOb3RlOiByZXR1cm5zIHBvaW50ZXIg
dG8gc3RhdGljIGRhdGEhDQogICovDQogY2hhciAqIGtkZXZuYW1lKGtkZXZf
dCBkZXYpDQogew0KLQlzdGF0aWMgY2hhciBidWZmZXJbMzJdOw0KKwlzdGF0
aWMgY2hhciBidWZmZXJbREVWX0JVRlNJWkVdOw0KKyNpZmRlZiBDT05GSUdf
REVWTkFNRV9IRVgNCiAJc3ByaW50ZihidWZmZXIsICIlMDJ4OiUwMngiLCBN
QUpPUihkZXYpLCBNSU5PUihkZXYpKTsNCisjZWxzZQ0KKwlzcHJpbnRmKGJ1
ZmZlciwgIiVkLCVkIiwgTUFKT1IoZGV2KSwgTUlOT1IoZGV2KSk7DQorI2Zp
DQogCXJldHVybiBidWZmZXI7DQogfQ0KKw0KKy8qDQorICogS2lsbCB0ZW1w
b3JhcnkgZGVmaW5lIHVzZWQgYWJvdmUuDQorICovDQorI3VuZGVmIERFVl9C
VUZTSVpFDQo=
--1421910094-1629831787-914084233=:15313--

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/