Re: [PATCH] i386 get_wchan() bugs (fs/proc/array.c)

Jamie Lokier (lkd@tantalophile.demon.co.uk)
Fri, 11 Dec 1998 18:41:57 +0000

On Fri, Dec 11, 1998 at 01:17:16PM -0500, Alex Buell wrote:
> > 2. The comparison ebp >= 8188+stack_page is followed by
>
> Just a point of order. Why isn't a constant being used instead of 8188?
>
> I can tell you it's VERY annoying grepping through code and changing each
> occurrence should this change in the future.

I agree. Feel free to submit a patch which defines one, and uses it
everywhere.

I expect it would be called KERNEL_STACK_SIZE or similar, and be i386
specific.

-- Jamie

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/