Re: [patch] entry.S asm improvement (removed some ugly jmp)

Andrea Arcangeli (andrea@e-mind.com)
Thu, 3 Dec 1998 01:01:42 +0100 (CET)


On Fri, 27 Nov 1998, Andrea Arcangeli wrote:

>This my patch (from arca-33) should be obviously right and will improve
>performance...

As far the old patch was not-obviously right this new one should improve
performance on > P5:

Index: linux/arch/i386/kernel/entry.S
diff -u linux/arch/i386/kernel/entry.S:1.1.1.2 linux/arch/i386/kernel/entry.S:1.1.1.1.2.3
--- linux/arch/i386/kernel/entry.S:1.1.1.2 Fri Nov 27 11:15:15 1998
+++ linux/arch/i386/kernel/entry.S Thu Dec 3 00:27:17 1998
@@ -237,14 +237,13 @@

ALIGN
handle_bottom_half:
- pushl $ret_from_intr
- jmp SYMBOL_NAME(do_bottom_half)
+ call SYMBOL_NAME(do_bottom_half)
+ jmp ret_from_intr

ALIGN
reschedule:
- pushl $ret_from_sys_call
- jmp SYMBOL_NAME(schedule) # test
-
+ call SYMBOL_NAME(schedule) # test
+ jmp ret_from_sys_call

ENTRY(divide_error)
pushl $0 # no error code

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/