Re: [PATCH} ngroups, list of groups to /proc/#/status

Topi Miettinen (Topi.Miettinen@medialab.sonera.net)
Sun, 22 Nov 1998 23:23:08 +0200


Chris Wedgwood writes:
> On Sun, Nov 22, 1998 at 05:35:28PM +0200, Topi Miettinen wrote:
>
> > + for (g = 0; g < p->ngroups; g++) {
> > + buffer += sprintf(buffer, "%d ", p->groups[g]);
> > + }
> > + buffer += sprintf(buffer, "\n");
>
> Although I wouldn't expect this to happen normally, its conceivable
> someone might one day up the maximum number of groups and in which
> case the above code might scribble of the end of the buffer....

Buffer seems to be one page, with recently suggested 32-bit ids this will
fill the entire buffer in a 4k-page system at around 373 groups. snprintf()
is not available?

-Topi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/