Re: [PATCH] Re: [ipchains] logging tcp/udp port numbers

H. Peter Anvin (hpa@transmeta.com)
20 Nov 1998 07:49:29 GMT


Followup to: <Pine.LNX.3.95.981119094910.2684B-100000@penguin.transmeta.com>
By author: Linus Torvalds <torvalds@transmeta.com>
In newsgroup: linux.dev.kernel
>
> Well, the argument against that is that va_args _shouldn't_do_that_then_.
>
> va_args() is a compiler specific thing anyway, and as such it would not be
> problematic to just make it do the right thing.
>
> I've changed the Linux kernel to do what the standard obviously says has
> to be done, but I'm just grumbling about a _stupid_ standard. va_args()
> should _know_ that short is promoted and do the right thing.
>
> Linus
>

This is true, but the fact of the matter is that it is really just a
fairly simple-minded macro to read a stack display on most machines
and compilers.

-hpa

-- 
    PGP: 2047/2A960705 BA 03 D3 2C 14 A8 A8 BD  1E DF FE 69 EE 35 BD 74
    See http://www.zytor.com/~hpa/ for web page and full PGP public key
        I am Bahá'í -- ask me about it or see http://www.bahai.org/
   "To love another person is to see the face of God." -- Les Misérables

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/