2.1.129pre5 and Config fixes

Andrzej Krzysztofowicz (ankry@green.mif.pg.gda.pl)
Wed, 18 Nov 1998 11:04:12 +0100 (CET)

Hi,
It seems to me that one of config fixes in 2.1.129pre5 is buggy:

-if [ "$CONFIG_IPX" != "n" ]; then
+if [ "$CONFIG_IPX" != "n" -o "$CONFIG_INET" != "n" ]; then
tristate 'NCP filesystem support (to mount NetWare volumes)' CONFIG_NCP_FS

[ it was buggy and remains buggy ]
The problem appears if "$CONFIG_NET" = "n". Then networking Config.in
is NOT proocessed and neither CONFIG_IPX nor CONFIG_INET is set.
So The above condition is TRUE in both variants
( [ "" != "n" -o "" != "n" ] is of course true)

I think that the '!= "n"' clause should be used very carefully, especially
for variables from another section.

Regards
Andrzej

-- 
=======================================================================
  Andrzej M. Krzysztofowicz               ankry@mif.pg.gda.pl
  phone (48)(58) 347 14 61
Faculty of Applied Phys. & Math.,   Technical University of Gdansk


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/