Re: Total freeze with 2.1.12[7,8]

Andrea Arcangeli (andrea@e-mind.com)
Mon, 16 Nov 1998 23:56:42 +0100 (CET)


On Mon, 16 Nov 1998, Pascal A. Dupuis wrote:

>I applied this patch on 2.1.128-ac2. Some parts already applied, one part
>I don't understand not applied :
>
>--- linux/arch/i386/kernel/irq.c:1.1.1.1 Fri Oct 2 19:23:36 1998
>+++ linux/arch/i386/kernel/irq.c Sat Nov 14 00:31:41 1998
>@@ -341,7 +341,7 @@
> atomic_read(&global_irq_count), local_irq_count[0],
>local_irq_count[1]);
> printk("bh: %d [%d %d]\n",
> atomic_read(&global_bh_count), local_bh_count[0],
>local_bh_count[1]);
>- stack = (unsigned long *) &str;
>+ stack = (unsigned long *) &stack;
> for (i = 40; i ; i--) {
> unsigned long x = *++stack;
> if (x > (unsigned long) &init_task_union && x < (unsigned
>long)
>&vsprintf) {
>
>"Stack" is an automatic variable initialised (and untouched) a few lines
>before. This patch is asking for troubles... "str" is an argument of the

I initialize stack with the address of stack (and this patch really is
from Ingo, I don' t want to take him CREDITS ;-). This make sense to me
since then the code use the stack value to scan the kernel stack searching
for valid kernel addresses (hopefully valid stack trace).

>Now, the important message is, hum : I don't get locks any more under
>netscape ! I browsed three sites, downloding files, clicking as mad

I don' t think to have fixed something. Please try to be more aggressive
against the `arca' kernel since it should lock as with clean 2.1.128.

Thanks for the report.

Andrea Arcangeli

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/