Re: NFS memory leak 2.1.128 (fixed?)

Mike Galbraith (mikeg@weiden.de)
Sun, 15 Nov 1998 07:04:42 +0100 (CET)


On Sat, 14 Nov 1998, Steven N. Hirsch wrote:
>
> On Sat, 14 Nov 1998, Mike Galbraith wrote:
>
> > Sorry to follow-up my own post, but I didn't really expect to find
> > a cure. Commenting out...
>
> (snip)
>
> > seems to cure it. Testing with both my laptop (unfs) mounted to my
> > desktop (knfs) and desktop mounted to itself, I see no more leak.
> > (iozone/bonnie/compile/edit all work from both systems)
> >
>
> Confirmed here as well. Thanks Mike! You ARE sure that this isn't just
> masking symptoms of another problem?

No, not at ALL sure. But, create_write_request() increments page->count
just a couple of lines up from here. I couldn't see any reason to have
back-to-back increments, so went for the gusto. The only thing I'm sure
of is beating the P out of it for hours produced no mushroom-clouds :)

-Mike

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/