Re: NFS memory leak 2.1.128 (fixed?)

Steven N. Hirsch (shirsch@adelphia.net)
Sat, 14 Nov 1998 18:40:40 -0500 (EST)


On Sat, 14 Nov 1998, Mike Galbraith wrote:

> Sorry to follow-up my own post, but I didn't really expect to find
> a cure. Commenting out...

(snip)

> seems to cure it. Testing with both my laptop (unfs) mounted to my
> desktop (knfs) and desktop mounted to itself, I see no more leak.
> (iozone/bonnie/compile/edit all work from both systems)
>

Confirmed here as well. Thanks Mike! You ARE sure that this isn't just
masking symptoms of another problem?

For the rest of us, here is the patch:

--- linux/fs/nfs/write.c.orig Fri Nov 13 07:08:30 1998
+++ linux/fs/nfs/write.c Sat Nov 14 16:13:40 1998
@@ -483,7 +483,7 @@
* Increment the usage count, and schedule the request (the
* end of the request will drop the usage count..)
*/
- atomic_inc(&page->count);
+ /* atomic_inc(&page->count); */

/* Schedule request */
synchronous = schedule_write_request(req, sync);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/