Re: [PATCH] Oops in framebuffer code.

Gerd Knorr (kraxel@goldbach.in-berlin.de)
Fri, 13 Nov 1998 19:53:38 +0100


In lists.linux.kernel you write:

>dwmw2@devel2.axiom.internal said:
>> With vesafb in 2.1.127, there's no fb_pan_display routine set, but
>> fbmem.c tries to call it upon a FBIOPAN_DISPLAY ioctl without first
>> checking that it's present. Not good.

>> Patch not compiled or tested, and it's probably in vger anyway, but
>> what the hell...

>Patch not working. Arse.

Here is a _tested_ one.

Gerd

-----------------------------------------------------------------------
--- drivers/video/vesafb.c-orig Fri Oct 9 22:06:46 1998
+++ drivers/video/vesafb.c Fri Oct 9 22:10:26 1998
@@ -126,10 +126,12 @@
}

static int vesafb_pan_display(struct fb_var_screeninfo *var, int con,
- struct fb_info *info)
+ struct fb_info *info)
{
int offset;

+ if (!ypan && !ywrap)
+ return -EINVAL;
if (var->xoffset)
return -EINVAL;
if (ypan && var->yoffset+var->yres > var->yres_virtual)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/