Re: 2.1.127 "->timeout" bugs

Ken Pizzini (ken@halcyon.com)
Sun, 08 Nov 1998 20:44:20 -0800


In linux-kernel,
message <Pine.LNX.3.96.981108141444.895B-100000@tjw30.joh.cam.ac.uk>,
Terence J. Wells <tjw30@cam.ac.uk> wrote:
>So far so good -- but unfortunately "schedule" wasn't the only
>function which used "->timeout": AFAICS "interruptible_sleep_on" (at
>least) did also. "interruptible_sleep_on" now also has an appropriate
>new version, "interruptible_sleep_on_timeout"
[snip]
>./drivers/cdrom/sonycd535.c (not sure -- should be like mcdx?)

Well, this one at least isn't really a problem.

First off, the only call to interruptable_sleep_on() is in a context
where no timeout is in effect. And besides, the branch which contains
interruptible_sleep_on() in sonycd535.c is never reached --- it is stub
code for "when interrupt mode is made to work", which is unlikely to
ever be implemented (due to a combination of inadequate documentation
and insufficient passion).

--Ken Pizzini

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/