Re: 2.1.127 "->timeout" bugs

Steven N. Hirsch (shirsch@adelphia.net)
Sun, 8 Nov 1998 14:41:03 -0500 (EST)


On Sun, 8 Nov 1998, Terence J. Wells wrote:

>
> So far so good -- but unfortunately "schedule" wasn't the only
> function which used "->timeout": AFAICS "interruptible_sleep_on" (at
> least) did also. "interruptible_sleep_on" now also has an appropriate
> new version, "interruptible_sleep_on_timeout"
>
> The trouble is, it's not being used... All the following files
> contained references to "->timeout" and "interruptible_sleep_on"
> before the task struct change, and now (2.1.127) _don't_ contain
> "interruptible_sleep_on_timeout". In some cases this may be correct
> (if "->timeout" was somehow being reset to 0 between calls in the old
> version), but at least in ./net/sunrpc/sched.c, between lines 918 and
> 928, this is not the case. I've weeded out those files which had been
> doing explicit resets (e.g. some of the sound drivers):
>
> ./net/sunrpc/sched.c (implicit ->timeout reset)
>

Bingo! I'll wager this is what breaks HJ Liu's knfsd patches to the RPC
subsystem.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/