On Tue, 03 Nov 1998, Konstantin B. Bukharov wrote:
>These kernels detect LS-120 fine, but while mounting disk or even after
>hdparm -t /dev/hdd kernel crashes with NULL dereferensing somewhere in
>idefloppy_end_request. Situation 100% reproducible.
The problem is that idefloppy_end_request gets called with a hwgroup that
does not contain a request. I don't think this should happen, but I'm too
lazy to track it down since I seem to get by by ignoring nonexistant
requests:
--- ide-floppy.c-org Thu Nov 5 17:50:01 1998
+++ ide-floppy.c Thu Nov 5 17:51:07 1998
@@ -634,6 +634,9 @@
if (error)
floppy->failed_pc = NULL;
+ if (!rq)
+ return;
+
if (!IDEFLOPPY_RQ_CMD (rq->cmd)) {
ide_end_request (uptodate, hwgroup);
return;
MfG, Ulrich
--
Besides, almost all dogs don't talk. Ones that do are merely a statistical
error, and can therefore be ignored.
T. Pratchett, "Men at Arms"
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/